From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org,
Harsha Sharma <harshasharmaiitr@gmail.com>
Subject: Re: [PATCH v2] extensions: libxt_hashlimit: Do not print default timeout and burst
Date: Tue, 16 Jan 2018 02:23:34 +0100 [thread overview]
Message-ID: <20180116012334.2g4o3dmpux7fbapc@salvia> (raw)
In-Reply-To: <20180115014532.GA13839@dimstar.local.net>
On Mon, Jan 15, 2018 at 12:45:32PM +1100, Duncan Roe wrote:
> On Wed, Jan 03, 2018 at 09:47:46AM +1100, Duncan Roe wrote:
> > On Sun, Dec 31, 2017 at 12:16:30AM +0100, Pablo Neira Ayuso wrote:
> ...
> > > > > @Duncan: I think you can update the wiki again after this, given that
> > > > > now those values should not be printed.
> > > >
> The examples now work as intended, so I updated the wiki. (INPUT is now being
> translated to input btw).
>
> It is still the case that if the iptables command specifies default burst or
> timeout then nothing is output for these, including the yetch case of specifying
> a limit (with or w/out a burst) and getting no timeout.
I think we should always print the timeout. This timeout depends on
umult which depends on the specified rate, inconditionally.
Burst, I think it's fine if we just provide a shorter translation
default value is specified.
Well, now the translation is correct as we don't print burst twice.
Anyway, if the translation is semantically correct and it works fine,
then this is fair good enough.
We're just provide a quick translation to ease migration, users will
have to look into specific nftables details sooner or later I guess.
Thanks.
next prev parent reply other threads:[~2018-01-16 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 7:28 [PATCH v2] extensions: libxt_hashlimit: Do not print default timeout and burst Harsha Sharma
2017-12-28 10:52 ` Pablo Neira Ayuso
2017-12-30 22:51 ` Duncan Roe
2017-12-30 23:16 ` Pablo Neira Ayuso
2018-01-02 22:47 ` Duncan Roe
2018-01-03 13:53 ` Pablo Neira Ayuso
2018-01-15 1:45 ` Duncan Roe
2018-01-16 1:23 ` Pablo Neira Ayuso [this message]
[not found] ` <20180116011537.b4xm2mxlabn5tsfl@salvia>
[not found] ` <20180116124143.5s6exg3467ozmobb@salvia>
[not found] ` <20180116204554.GA27044@dimstar.local.net>
[not found] ` <20180116215217.GA27232@dimstar.local.net>
[not found] ` <20180116223930.ftuagn4vtkvd2nka@salvia>
[not found] ` <20180119014815.GA4882@dimstar.local.net>
[not found] ` <20180119022722.duu5l3esazkox43z@salvia>
[not found] ` <20180119022757.z5ir6zcytaabqntc@salvia>
2018-01-20 6:11 ` Duncan Roe
2018-01-20 9:21 ` Pablo Neira Ayuso
2018-01-20 12:47 ` Pablo Neira Ayuso
2018-01-20 13:35 ` Duncan Roe
2018-01-20 13:42 ` Duncan Roe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116012334.2g4o3dmpux7fbapc@salvia \
--to=pablo@netfilter.org \
--cc=harshasharmaiitr@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).