From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thierry Du Tre <thierry@dtsystems.be>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] extensions : multiple to-dst/to-src arguments for ip6t_DNAT/SNAT not reported
Date: Tue, 16 Jan 2018 16:19:26 +0100 [thread overview]
Message-ID: <20180116151926.6expjmydoddpnwb2@salvia> (raw)
In-Reply-To: <65034694-62fb-3e6a-b15c-1176e65eae65@dtsystems.be>
On Tue, Jan 16, 2018 at 01:44:37PM +0100, Thierry Du Tre wrote:
> This patch is fixing the detection of multiple '--to-destination' in a DNAT rule and '--to-source' in SNAT rule for IPv6.
> Currently, when defining multiple values for these, only the last will be used and others ignored silently.
>
> The checks for (cb->xflags & F_X_TO_[DEST/SRC]) always fails because the flags are never set before.
> It seems to be a copy-paste artefact since introduction of the IPv6 DNAT/SNAT extensions based on IPv4 code.
>
> I also removed the kernel_version checks because they seem useless. Extensions for IPv6 DNAT/SNAT are using xt_target with revision 1.
> That seems only added since kernel version 3.7-rc1 and therefore the check for > v2.6.10 will always return true.
> The check is probably also coming from the IPv4 copy-paste.
Applied, thanks Thierry.
prev parent reply other threads:[~2018-01-16 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 12:44 [PATCH] extensions : multiple to-dst/to-src arguments for ip6t_DNAT/SNAT not reported Thierry Du Tre
2018-01-16 13:06 ` Pablo Neira Ayuso
2018-01-16 15:06 ` Thierry Du Tre
2018-01-16 15:19 ` Pablo Neira Ayuso
2018-01-16 15:20 ` Thierry Du Tre
2018-01-16 15:23 ` Pablo Neira Ayuso
2018-01-16 15:24 ` Pablo Neira Ayuso
2018-01-16 15:31 ` Thierry Du Tre
2018-01-16 15:41 ` Pablo Neira Ayuso
2018-01-16 15:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116151926.6expjmydoddpnwb2@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=thierry@dtsystems.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).