* [nf-next:master 27/32] net/netfilter/nf_tables_api.c:4331:19: sparse: symbol 'nf_tables_obj_lookup_byhandle' was not declared. Should it be static?
@ 2018-01-19 20:27 kbuild test robot
2018-01-19 20:27 ` [RFC PATCH nf-next] netfilter: nf_tables: nf_tables_obj_lookup_byhandle() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2018-01-19 20:27 UTC (permalink / raw)
To: Harsha Sharma; +Cc: kbuild-all, netfilter-devel, coreteam, Pablo Neira Ayuso
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
head: e55311665286ab2744295575948c2b08dc001bf3
commit: 3ecbfd65f50e5ff9c538c1bfa3356ef52cc66586 [27/32] netfilter: nf_tables: allocate handle and delete objects via handle
reproduce:
# apt-get install sparse
git checkout 3ecbfd65f50e5ff9c538c1bfa3356ef52cc66586
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
net/netfilter/nf_tables_api.c:1180:31: sparse: incorrect type in return expression (different address spaces) @@ expected struct nft_stats @@ got @@
net/netfilter/nf_tables_api.c:1180:31: expected struct nft_stats
net/netfilter/nf_tables_api.c:1180:31: got void COPYING CREDITS Documentation Kbuild Kconfig MAINTAINERS Makefile README arch block certs crypto drivers firmware fs include init ipc kernel lib mm net samples scripts security sound tools usr virt
net/netfilter/nf_tables_api.c:1183:31: sparse: incorrect type in return expression (different address spaces) @@ expected struct nft_stats @@ got @@
net/netfilter/nf_tables_api.c:1183:31: expected struct nft_stats
net/netfilter/nf_tables_api.c:1183:31: got void COPYING CREDITS Documentation Kbuild Kconfig MAINTAINERS Makefile README arch block certs crypto drivers firmware fs include init ipc kernel lib mm net samples scripts security sound tools usr virt
net/netfilter/nf_tables_api.c:1187:31: sparse: incorrect type in return expression (different address spaces) @@ expected struct nft_stats @@ got @@
net/netfilter/nf_tables_api.c:1187:31: expected struct nft_stats
net/netfilter/nf_tables_api.c:1187:31: got void COPYING CREDITS Documentation Kbuild Kconfig MAINTAINERS Makefile README arch block certs crypto drivers firmware fs include init ipc kernel lib mm net samples scripts security sound tools usr virt
net/netfilter/nf_tables_api.c:1210:28: sparse: cast between address spaces (<asn:3>-><asn:4>)
net/netfilter/nf_tables_api.c:1210:28: sparse: incompatible types in comparison expression (different address spaces)
net/netfilter/nf_tables_api.c:1464:23: sparse: incorrect type in assignment (different address spaces) @@ expected struct nft_stats @@ got struct nft_stats struct nft_stats @@
net/netfilter/nf_tables_api.c:1472:29: sparse: incorrect type in argument 1 (different address spaces) @@ expected void @@ got @@
net/netfilter/nf_tables_api.c:1476:38: sparse: incorrect type in assignment (different address spaces) @@ expected struct nft_stats @@ got @@
net/netfilter/nf_tables_api.c:1490:37: sparse: incorrect type in argument 1 (different address spaces) @@ expected void @@ got @@
>> net/netfilter/nf_tables_api.c:4331:19: sparse: symbol 'nf_tables_obj_lookup_byhandle' was not declared. Should it be
net/netfilter/nf_tables_api.c:4360:41: sparse: Variable length array is used.
>> net/netfilter/nf_tables_api.c:4853:22: sparse: symbol 'nf_tables_flowtable_lookup_byhandle' was not declared. Should it be
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH nf-next] netfilter: nf_tables: nf_tables_obj_lookup_byhandle() can be static
2018-01-19 20:27 [nf-next:master 27/32] net/netfilter/nf_tables_api.c:4331:19: sparse: symbol 'nf_tables_obj_lookup_byhandle' was not declared. Should it be static? kbuild test robot
@ 2018-01-19 20:27 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2018-01-19 20:27 UTC (permalink / raw)
To: Harsha Sharma; +Cc: kbuild-all, netfilter-devel, coreteam, Pablo Neira Ayuso
Fixes: 3ecbfd65f50e ("netfilter: nf_tables: allocate handle and delete objects via handle")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
nf_tables_api.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 1addc401..b0129a0 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -4328,9 +4328,9 @@ struct nft_object *nf_tables_obj_lookup(const struct nft_table *table,
}
EXPORT_SYMBOL_GPL(nf_tables_obj_lookup);
-struct nft_object *nf_tables_obj_lookup_byhandle(const struct nft_table *table,
- const struct nlattr *nla,
- u32 objtype, u8 genmask)
+static struct nft_object *nf_tables_obj_lookup_byhandle(const struct nft_table *table,
+ const struct nlattr *nla,
+ u32 objtype, u8 genmask)
{
struct nft_object *obj;
@@ -4850,7 +4850,7 @@ struct nft_flowtable *nf_tables_flowtable_lookup(const struct nft_table *table,
}
EXPORT_SYMBOL_GPL(nf_tables_flowtable_lookup);
-struct nft_flowtable *
+static struct nft_flowtable *
nf_tables_flowtable_lookup_byhandle(const struct nft_table *table,
const struct nlattr *nla, u8 genmask)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 20:27 [nf-next:master 27/32] net/netfilter/nf_tables_api.c:4331:19: sparse: symbol 'nf_tables_obj_lookup_byhandle' was not declared. Should it be static? kbuild test robot
2018-01-19 20:27 ` [RFC PATCH nf-next] netfilter: nf_tables: nf_tables_obj_lookup_byhandle() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).