From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netdev <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_match()
Date: Thu, 25 Jan 2018 00:19:52 +0100 [thread overview]
Message-ID: <20180124231952.GC14192@breakpoint.cc> (raw)
In-Reply-To: <1516834188.3715.35.camel@gmail.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> It looks like syzbot found its way into netfilter territory.
Excellent. This will sure allow to find and fix more bugs :-)
> Issue here is that @name comes from user space and might
> not be null terminated.
Indeed, thanks for fixing this Eric.
xt_find_target() and xt_find_table_lock() might have similar issues.
next prev parent reply other threads:[~2018-01-24 23:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 22:49 [PATCH net] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_match() Eric Dumazet
2018-01-24 23:19 ` Florian Westphal [this message]
2018-01-24 23:50 ` Pablo Neira Ayuso
2018-01-25 0:13 ` Pablo Neira Ayuso
2018-01-25 1:13 ` Eric Dumazet
2018-01-25 1:16 ` [PATCH v2 net] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_{match|target} Eric Dumazet
2018-01-25 6:09 ` Florian Westphal
2018-01-25 11:33 ` Pablo Neira Ayuso
2018-01-24 23:49 ` [PATCH net] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_match() Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124231952.GC14192@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).