[PATCH nft] tests: build: Add enable man page option.

[PATCH nft] tests: build: Add enable man page option.

[Varsha Rao]

Add test for man page compile option.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 tests/build/README       | 1 +
 tests/build/run-tests.sh | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/build/README b/tests/build/README
index 8eca252..dfe344b 100644
--- a/tests/build/README
+++ b/tests/build/README
@@ -5,6 +5,7 @@ In this testsuite, automated testing is done for following nft compile options:
   cli support
   enable debugging symbols
   use mini-gmp
+  enable man page
   enable pdf documentation
   libxtables support
 
diff --git a/tests/build/run-tests.sh b/tests/build/run-tests.sh
index 36cd8d8..109b2b5 100755
--- a/tests/build/run-tests.sh
+++ b/tests/build/run-tests.sh
@@ -9,7 +9,8 @@ log_file="`pwd`/tests.log"
 tarball="nftables-0.8.1.tar.bz2"
 dir=../..
 cmd=./configure
-argument=( --without-cli --enable-debug --with-mini-gmp --enable-pdf-doc --with-xtables )
+argument=( --without-cli --enable-debug --with-mini-gmp --enable-man-doc
+	    --enable-pdf-doc --with-xtables)
 ok=0
 failed=0
 
-- 
2.14.3

[PATCH nft] configure: Remove macro AC_CHECK_FUNCS

[Varsha Rao]

Functions memmove, strchr, strerror and strdup are defined in string.h
header file. Also, strtoull is defined in stdlib.h header file. These
header files are checked by AC_CHECK_HEADERS macro. AC_CHECK_FUNCS macro
is not required, so remove it.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 configure.ac | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 71d30d8..48af28c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -128,9 +128,6 @@ AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h limits.h malloc.h \
 		  stddef.h stdint.h stdlib.h string.h unistd.h], ,
 		 AC_MSG_ERROR([Header file not found]))
 
-# Checks for library functions.
-AC_CHECK_FUNCS([memmove memset strchr strdup strerror strtoull])
-
 AC_CONFIG_FILES([					\
 		Makefile				\
 		src/Makefile				\
-- 
2.14.3

Re: [PATCH nft] tests: build: Add enable man page option.

[Pablo Neira Ayuso]

On Thu, Jan 25, 2018 at 08:48:52PM +0530, Varsha Rao wrote:
> Add test for man page compile option.

Applied, thanks Varsha.

Re: [PATCH nft] configure: Remove macro AC_CHECK_FUNCS

[Pablo Neira Ayuso]

On Thu, Jan 25, 2018 at 08:48:53PM +0530, Varsha Rao wrote:
> Functions memmove, strchr, strerror and strdup are defined in string.h
> header file. Also, strtoull is defined in stdlib.h header file. These
> header files are checked by AC_CHECK_HEADERS macro. AC_CHECK_FUNCS macro
> is not required, so remove it.

Also applied, thanks.