From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
f.fainelli@gmail.com, ronye@mellanox.com,
simon.horman@netronome.com, jiri@mellanox.com, nbd@nbd.name,
john@phrozen.org, fw@strlen.de
Subject: Re: [PATCH nf-next,RFC v4] netfilter: nf_flow_table: add hardware offload support
Date: Mon, 29 Jan 2018 11:37:21 +0100 [thread overview]
Message-ID: <20180129103721.mbumauzre4whnc2k@salvia> (raw)
In-Reply-To: <20180125143846.6bb5290f@cakuba.netronome.com>
Hi Jakub,
On Thu, Jan 25, 2018 at 02:38:46PM -0800, Jakub Kicinski wrote:
> On Thu, 25 Jan 2018 12:28:58 +0100, Pablo Neira Ayuso wrote:
[...]
> Ah, I must be misunderstanding. I meant when device is removed, not
> the flow_table_hw module. Does the nf_flow_table_hw_module_exit() run
> when device is removed? I was expecting that, for example something
> like nft_flow_offload_iterate_cleanup() would queue up all the flow
> remove calls and then call flush_work() (not cancel_work).
Oh right indeed, I need some code there to release all hw resources on
module removal.
Will revamp and send v5.
Thanks for reviewing!
prev parent reply other threads:[~2018-01-29 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 0:09 [PATCH nf-next,RFC v4] netfilter: nf_flow_table: add hardware offload support Pablo Neira Ayuso
2018-01-25 1:31 ` Jakub Kicinski
2018-01-25 11:28 ` Pablo Neira Ayuso
2018-01-25 22:38 ` Jakub Kicinski
2018-01-29 10:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129103721.mbumauzre4whnc2k@salvia \
--to=pablo@netfilter.org \
--cc=f.fainelli@gmail.com \
--cc=fw@strlen.de \
--cc=jiri@mellanox.com \
--cc=john@phrozen.org \
--cc=kubakici@wp.pl \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ronye@mellanox.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).