From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: nbd@nbd.name
Subject: [PATCH nf 1/3] netfilter: nft_flow_offload: no need to flush entries on module removal
Date: Tue, 6 Feb 2018 02:22:25 +0100 [thread overview]
Message-ID: <20180206012227.13716-1-pablo@netfilter.org> (raw)
nft_flow_offload module removal does not require to flush existing
flowtables, it is valid to remove this module while keeping flowtables
around.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
This patch is a dependency for bugfix in patch 3/3. PATCH 2/3 moves
flowtable cleanup to the core, this patch saves us from exporting a
function that we would need to unexport just thereafter. So remove it
in first place to avoid unnecessary code churning.
net/netfilter/nft_flow_offload.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c
index 1739ff8ca21f..e5c45c7ac02a 100644
--- a/net/netfilter/nft_flow_offload.c
+++ b/net/netfilter/nft_flow_offload.c
@@ -247,14 +247,8 @@ static int __init nft_flow_offload_module_init(void)
static void __exit nft_flow_offload_module_exit(void)
{
- struct net *net;
-
nft_unregister_expr(&nft_flow_offload_type);
unregister_netdevice_notifier(&flow_offload_netdev_notifier);
- rtnl_lock();
- for_each_net(net)
- nft_flow_table_iterate(net, nft_flow_offload_iterate_cleanup, NULL);
- rtnl_unlock();
}
module_init(nft_flow_offload_module_init);
--
2.11.0
next reply other threads:[~2018-02-06 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 1:22 Pablo Neira Ayuso [this message]
2018-02-06 1:22 ` [PATCH nf 2/3] netfilter: nft_flow_offload: move flowtable cleanup routines to nf_flow_table Pablo Neira Ayuso
2018-02-06 1:22 ` [PATCH nf 3/3] netfilter: nf_tables: fix flowtable free Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206012227.13716-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=nbd@nbd.name \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).