From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: [PATCH nf 1/3] netfilter: nft_flow_offload: no need to flush entries on module removal Date: Tue, 6 Feb 2018 02:22:25 +0100 Message-ID: <20180206012227.13716-1-pablo@netfilter.org> Cc: nbd@nbd.name To: netfilter-devel@vger.kernel.org Return-path: Received: from mail.us.es ([193.147.175.20]:41748 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbeBFBWf (ORCPT ); Mon, 5 Feb 2018 20:22:35 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 217921EC2C3 for ; Tue, 6 Feb 2018 02:22:34 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 14898DA787 for ; Tue, 6 Feb 2018 02:22:34 +0100 (CET) Sender: netfilter-devel-owner@vger.kernel.org List-ID: nft_flow_offload module removal does not require to flush existing flowtables, it is valid to remove this module while keeping flowtables around. Signed-off-by: Pablo Neira Ayuso --- This patch is a dependency for bugfix in patch 3/3. PATCH 2/3 moves flowtable cleanup to the core, this patch saves us from exporting a function that we would need to unexport just thereafter. So remove it in first place to avoid unnecessary code churning. net/netfilter/nft_flow_offload.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c index 1739ff8ca21f..e5c45c7ac02a 100644 --- a/net/netfilter/nft_flow_offload.c +++ b/net/netfilter/nft_flow_offload.c @@ -247,14 +247,8 @@ static int __init nft_flow_offload_module_init(void) static void __exit nft_flow_offload_module_exit(void) { - struct net *net; - nft_unregister_expr(&nft_flow_offload_type); unregister_netdevice_notifier(&flow_offload_netdev_notifier); - rtnl_lock(); - for_each_net(net) - nft_flow_table_iterate(net, nft_flow_offload_iterate_cleanup, NULL); - rtnl_unlock(); } module_init(nft_flow_offload_module_init); -- 2.11.0