From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 06/11] netfilter: nft_flow_offload: no need to flush entries on module removal
Date: Wed, 7 Feb 2018 18:42:24 +0100 [thread overview]
Message-ID: <20180207174229.4098-7-pablo@netfilter.org> (raw)
In-Reply-To: <20180207174229.4098-1-pablo@netfilter.org>
nft_flow_offload module removal does not require to flush existing
flowtables, it is valid to remove this module while keeping flowtables
around.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/netfilter/nft_flow_offload.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c
index 1739ff8ca21f..e5c45c7ac02a 100644
--- a/net/netfilter/nft_flow_offload.c
+++ b/net/netfilter/nft_flow_offload.c
@@ -247,14 +247,8 @@ static int __init nft_flow_offload_module_init(void)
static void __exit nft_flow_offload_module_exit(void)
{
- struct net *net;
-
nft_unregister_expr(&nft_flow_offload_type);
unregister_netdevice_notifier(&flow_offload_netdev_notifier);
- rtnl_lock();
- for_each_net(net)
- nft_flow_table_iterate(net, nft_flow_offload_iterate_cleanup, NULL);
- rtnl_unlock();
}
module_init(nft_flow_offload_module_init);
--
2.11.0
next prev parent reply other threads:[~2018-02-07 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 17:42 [PATCH 00/11] Netfilter fixes for net Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 01/11] netfilter: x_tables: make allocation less aggressive Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 02/11] netfilter: ipv6: nf_defrag: Kill frag queue on RFC2460 failure Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 03/11] netfilter: flowtable infrastructure depends on NETFILTER_INGRESS Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 04/11] netfilter: xt_cgroup: initialize info->priv in cgroup_mt_check_v1() Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 05/11] netfilter: nft_flow_offload: wait for garbage collector to run after cleanup Pablo Neira Ayuso
2018-02-07 17:42 ` Pablo Neira Ayuso [this message]
2018-02-07 17:42 ` [PATCH 07/11] netfilter: xt_RATEEST: acquire xt_rateest_mutex for hash insert Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 08/11] netfilter: nft_flow_offload: move flowtable cleanup routines to nf_flow_table Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 09/11] netfilter: nf_tables: fix flowtable free Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 10/11] netfilter: remove useless prototype Pablo Neira Ayuso
2018-02-07 17:42 ` [PATCH 11/11] netfilter: nf_flow_offload: fix use-after-free and a resource leak Pablo Neira Ayuso
2018-02-07 18:56 ` [PATCH 00/11] Netfilter fixes for net David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207174229.4098-7-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).