[PATCH net-next 0/6] Converting pernet_operations (part #8)

[PATCH net-next 0/6] Converting pernet_operations (part #8)

[Kirill Tkhai]

Hi,

this series continues to review and to convert pernet_operations
to make them possible to be executed in parallel for several
net namespaces at the same time. There are different operations
over the tree, mostly are ipvs.


Thanks,
Kirill
---

Kirill Tkhai (6):
      net: Convert l2tp_net_ops
      net: Convert mpls_net_ops
      net: Convert ovs_net_ops
      net: Convert ipvs_core_ops
      net: Convert ipvs_core_dev_ops
      net: Convert ip_vs_ftp_ops


 net/l2tp/l2tp_core.c            |    1 +
 net/mpls/af_mpls.c              |    1 +
 net/netfilter/ipvs/ip_vs_core.c |    2 ++
 net/netfilter/ipvs/ip_vs_ftp.c  |    1 +
 net/openvswitch/datapath.c      |    1 +
 5 files changed, 6 insertions(+)

--
Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>

[PATCH net-next 1/6] net: Convert l2tp_net_ops

[Kirill Tkhai]

Init method is rather simple. Exit method queues del_work
for every tunnel from per-net list. This seems to be safe
to be marked async.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/l2tp/l2tp_core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 83421c6f0bef..189a12a5e4ac 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1787,6 +1787,7 @@ static struct pernet_operations l2tp_net_ops = {
 	.exit = l2tp_exit_net,
 	.id   = &l2tp_net_id,
 	.size = sizeof(struct l2tp_net),
+	.async = true,
 };
 
 static int __init l2tp_init(void)

Re: [PATCH net-next 1/6] net: Convert l2tp_net_ops

[Guillaume Nault]

On Thu, Mar 15, 2018 at 12:10:57PM +0300, Kirill Tkhai wrote:
> Init method is rather simple. Exit method queues del_work
> for every tunnel from per-net list. This seems to be safe
> to be marked async.
> 
Acked-by: Guillaume Nault <g.nault-pHk1y4uTXVDytLWWfqlThQ@public.gmane.org>

[PATCH net-next 2/6] net: Convert mpls_net_ops

[Kirill Tkhai]

These pernet_operations register and unregister sysctl table.
Exit methods frees platform_labels from net::mpls::platform_label.
Everything is per-net, and they looks safe to be marked async.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/mpls/af_mpls.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 7a4de6d618b1..d4a89a8be013 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -2488,6 +2488,7 @@ static void mpls_net_exit(struct net *net)
 static struct pernet_operations mpls_net_ops = {
 	.init = mpls_net_init,
 	.exit = mpls_net_exit,
+	.async = true,
 };
 
 static struct rtnl_af_ops mpls_af_ops __read_mostly = {

[PATCH net-next 3/6] net: Convert ovs_net_ops

[Kirill Tkhai]

These pernet_operations initialize and destroy net_generic()
data pointed by ovs_net_id. Exit method destroys vports from
alive net to exiting net. Since they are only pernet_operations
interested in this data, and exit method is executed under
exclusive global lock (ovs_mutex), they are safe to be executed
in parallel.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/openvswitch/datapath.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index ef38e5aecd28..100191df0371 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -2384,6 +2384,7 @@ static struct pernet_operations ovs_net_ops = {
 	.exit = ovs_exit_net,
 	.id   = &ovs_net_id,
 	.size = sizeof(struct ovs_net),
+	.async = true,
 };
 
 static int __init dp_init(void)

[PATCH net-next 4/6] net: Convert ipvs_core_ops

[Kirill Tkhai]

These pernet_operations register and unregister nf hooks,
/proc entries, sysctl, percpu statistics. There are several
global lists, and the only list modified without exclusive
locks is ip_vs_conn_tab in ip_vs_conn_flush(). We iterate
the list and force the timers expire at the moment. Since
there were possible several timer expirations before this
patch, and since they are safe, the patch does not invent
new parallelism of their destruction. These pernet_operations
look safe to be converted.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/netfilter/ipvs/ip_vs_core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index 5f6f73cf2174..c5d16e2bc8e2 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -2289,6 +2289,7 @@ static struct pernet_operations ipvs_core_ops = {
 	.exit = __ip_vs_cleanup,
 	.id   = &ip_vs_net_id,
 	.size = sizeof(struct netns_ipvs),
+	.async = true,
 };
 
 static struct pernet_operations ipvs_core_dev_ops = {

[PATCH net-next 5/6] net: Convert ipvs_core_dev_ops

[Kirill Tkhai]

Exit method stops two per-net threads and cancels
delayed work. Everything looks nicely per-net divided.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/netfilter/ipvs/ip_vs_core.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index c5d16e2bc8e2..6a6cb9db030b 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -2294,6 +2294,7 @@ static struct pernet_operations ipvs_core_ops = {
 
 static struct pernet_operations ipvs_core_dev_ops = {
 	.exit = __ip_vs_dev_cleanup,
+	.async = true,
 };
 
 /*

[PATCH net-next 6/6] net: Convert ip_vs_ftp_ops

[Kirill Tkhai]

These pernet_operations register and unregister ipvs app.
register_ip_vs_app(), unregister_ip_vs_app() and
register_ip_vs_app_inc() modify per-net structures,
and there are no global structures touched. So,
this looks safe to be marked as async.

Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
---
 net/netfilter/ipvs/ip_vs_ftp.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c
index 58d5d05aec24..8b25aab41928 100644
--- a/net/netfilter/ipvs/ip_vs_ftp.c
+++ b/net/netfilter/ipvs/ip_vs_ftp.c
@@ -479,6 +479,7 @@ static void __ip_vs_ftp_exit(struct net *net)
 static struct pernet_operations ip_vs_ftp_ops = {
 	.init = __ip_vs_ftp_init,
 	.exit = __ip_vs_ftp_exit,
+	.async = true,
 };
 
 static int __init ip_vs_ftp_init(void)

Re: [PATCH net-next 0/6] Converting pernet_operations (part #8)

[Julian Anastasov]

	Hello,

On Thu, 15 Mar 2018, Kirill Tkhai wrote:

> Hi,
> 
> this series continues to review and to convert pernet_operations
> to make them possible to be executed in parallel for several
> net namespaces at the same time. There are different operations
> over the tree, mostly are ipvs.
> 
> 
> Thanks,
> Kirill
> ---
> 
> Kirill Tkhai (6):
>       net: Convert l2tp_net_ops
>       net: Convert mpls_net_ops
>       net: Convert ovs_net_ops
>       net: Convert ipvs_core_ops
>       net: Convert ipvs_core_dev_ops
>       net: Convert ip_vs_ftp_ops

	The IPVS patches 4-6 look good to me,

Acked-by: Julian Anastasov <ja-FgGsKACvmQM@public.gmane.org>

>  net/l2tp/l2tp_core.c            |    1 +
>  net/mpls/af_mpls.c              |    1 +
>  net/netfilter/ipvs/ip_vs_core.c |    2 ++
>  net/netfilter/ipvs/ip_vs_ftp.c  |    1 +
>  net/openvswitch/datapath.c      |    1 +
>  5 files changed, 6 insertions(+)
> 
> --
> Signed-off-by: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>

Regards

--
Julian Anastasov <ja-FgGsKACvmQM@public.gmane.org>

Re: [PATCH net-next 0/6] Converting pernet_operations (part #8)

[David Miller]

From: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
Date: Thu, 15 Mar 2018 12:10:47 +0300

> this series continues to review and to convert pernet_operations
> to make them possible to be executed in parallel for several
> net namespaces at the same time. There are different operations
> over the tree, mostly are ipvs.

Series applied, thanks Kirill.

Re: [PATCH net-next 0/6] Converting pernet_operations (part #8)

[Kirill Tkhai]

On 18.03.2018 00:07, David Miller wrote:
> From: Kirill Tkhai <ktkhai-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
> Date: Thu, 15 Mar 2018 12:10:47 +0300
> 
>> this series continues to review and to convert pernet_operations
>> to make them possible to be executed in parallel for several
>> net namespaces at the same time. There are different operations
>> over the tree, mostly are ipvs.
> 
> Series applied, thanks Kirill.

Thanks, David!