netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 44/47] netfilter: Merge assignment with return
Date: Fri, 30 Mar 2018 13:46:16 +0200	[thread overview]
Message-ID: <20180330114619.18797-5-pablo@netfilter.org> (raw)
In-Reply-To: <20180330114619.18797-1-pablo@netfilter.org>

From: Arushi Singhal <arushisinghal19971997@gmail.com>

Merge assignment with return statement to directly return the value.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nf_conntrack_netlink.c | 5 ++---
 net/netfilter/xt_hashlimit.c         | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 11ef85a57244..b00e84bf4107 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -1527,9 +1527,8 @@ ctnetlink_setup_nat(struct nf_conn *ct, const struct nlattr * const cda[])
 	if (ret < 0)
 		return ret;
 
-	ret = ctnetlink_parse_nat_setup(ct, NF_NAT_MANIP_SRC,
-					cda[CTA_NAT_SRC]);
-	return ret;
+	return ctnetlink_parse_nat_setup(ct, NF_NAT_MANIP_SRC,
+					 cda[CTA_NAT_SRC]);
 #else
 	if (!cda[CTA_NAT_DST] && !cda[CTA_NAT_SRC])
 		return 0;
diff --git a/net/netfilter/xt_hashlimit.c b/net/netfilter/xt_hashlimit.c
index db2fe0911740..64fc3721d74c 100644
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -534,8 +534,7 @@ static u64 user2rate_bytes(u32 user)
 	u64 r;
 
 	r = user ? U32_MAX / user : U32_MAX;
-	r = (r - 1) << XT_HASHLIMIT_BYTE_SHIFT;
-	return r;
+	return (r - 1) << XT_HASHLIMIT_BYTE_SHIFT;
 }
 
 static void rateinfo_recalc(struct dsthash_ent *dh, unsigned long now,
-- 
2.11.0

  parent reply	other threads:[~2018-03-30 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 11:46 [PATCH 40/47] netfilter: nf_tables: build-in filter chain type Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 41/47] netfilter: nf_tables: enable conntrack if NAT chain is registered Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 42/47] netfilter: nf_tables: rename to nft_set_lookup_global() Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 43/47] netfilter: nf_tables: use nft_set_lookup_global from nf_tables_newsetelem() Pablo Neira Ayuso
2018-03-30 11:46 ` Pablo Neira Ayuso [this message]
2018-03-30 11:46 ` [PATCH 45/47] netfilter: x_tables: Add note about how to free percpu counters Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 46/47] Revert "netfilter: x_tables: ensure last rule in base chain matches underflow/policy" Pablo Neira Ayuso
2018-03-30 11:46 ` [PATCH 47/47] netfilter: ipset: Use is_zero_ether_addr instead of static and memcmp Pablo Neira Ayuso
2018-04-04 15:38 ` [PATCH 40/47] netfilter: nf_tables: build-in filter chain type Arnd Bergmann
2018-04-04 15:46   ` Pablo Neira Ayuso
2018-04-04 15:50     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180330114619.18797-5-pablo@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).