From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH 09/14] net: sched: don't release reference on action overwrite Date: Sat, 19 May 2018 18:52:46 -0300 Message-ID: <20180519215246.GD5488@localhost.localdomain> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-10-git-send-email-vladbu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com To: Vlad Buslov Return-path: Content-Disposition: inline In-Reply-To: <1526308035-12484-10-git-send-email-vladbu@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote: > Return from action init function with reference to action taken, > even when overwriting existing action. Isn't this patch necessary before patch 7, to not break things up? AFAICU after patchset 7 it assumes the action init function is already behaving like this.