From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: nft_numgen: fix ptr_ret.cocci warnings Date: Fri, 1 Jun 2018 09:46:39 +0200 Message-ID: <20180601074639.ptk6zpp2crvunzap@salvia> References: <201805231855.2507c2Vh%fengguang.wu@intel.com> <20180523105859.GA74092@ivb42> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild test robot , kbuild-all@01.org, Jozsef Kadlecsik , Florian Westphal , Netfilter Development Mailing list , coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Laura Garcia Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Thu, May 24, 2018 at 12:40:04PM +0200, Laura Garcia wrote: > On Wed, May 23, 2018 at 12:58 PM, kbuild test robot > wrote: > > From: kbuild test robot > > > > net/netfilter/nft_numgen.c:117:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > > > Fixes: d734a2888922 ("netfilter: nft_numgen: add map lookups for numgen statements") > > CC: Laura Garcia Liebana > > Signed-off-by: kbuild test robot > > Acked-by: Laura Garcia Liebana Applied, thanks.