From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Howells <dhowells@redhat.com>
Cc: linux-api@vger.kernel.org, linux-kbuild@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [netfilter-core] [PATCH 07/11] UAPI: netfilter: Fix symbol collision issues [ver #2]
Date: Fri, 28 Sep 2018 15:07:04 +0200 [thread overview]
Message-ID: <20180928130704.kcmsnsecp6aqpk66@salvia> (raw)
In-Reply-To: <153622555128.14298.11612304975343930534.stgit@warthog.procyon.org.uk>
On Thu, Sep 06, 2018 at 10:19:11AM +0100, David Howells wrote:
> The netfilter UAPI headers have some symbol collision issues:
>
> (1) "enum nfnl_acct_msg_types" is defined twice, and each definition is
> completely different.
>
> Fix this by renaming the one in nfnetlink_cthelper.h to be "enum
> nfnl_cthelper_types" to be consistent with the other things in that
> file.
>
> (2) There's a disagreement between ipt_ECN.h and ipt_ecn.h over the
> definition of various IPT_ECN_* constants, leading to an error over
> IPT_ECN_IP_MASK being substituted when being defined as an enum value
> in ipt_ecn.h if ipt_ECN.h is #included first.
>
> Fix this by removing the conflicting constants from ipt_ECN.h and
> including ipt_ecn.h instead.
David, may I upstream this or you will pass it to Greg? I can just
take this, as you prefer.
Thanks.
next prev parent reply other threads:[~2018-09-28 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 9:18 [RFC] UAPI: Check headers by compiling all together as C++ David Howells
2018-09-06 9:19 ` [PATCH 07/11] UAPI: netfilter: Fix symbol collision issues [ver #2] David Howells
2018-09-10 17:32 ` kbuild test robot
2018-09-28 13:07 ` Pablo Neira Ayuso [this message]
2018-10-09 15:35 ` [netfilter-core] " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928130704.kcmsnsecp6aqpk66@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=dhowells@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).