netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: stable@vger.kernel.org,
	netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: stable regression: revert request for netfilter ipv6 defrag bug
Date: Wed, 31 Oct 2018 11:07:53 -0400	[thread overview]
Message-ID: <20181031150753.GR194472@sasha-vm> (raw)
In-Reply-To: <20181024103104.72liko3nrf4pqwqa@breakpoint.cc>

On Wed, Oct 24, 2018 at 12:31:04PM +0200, Florian Westphal wrote:
>Hi,
>
>please consider reverting
>
>commit 84379c9afe011020e797e3f50a662b08a6355dcf
>netfilter: ipv6: nf_defrag: drop skb dst before queueing
>
>It causes kernel crash for locally generated ipv6 fragments
>when netfilter ipv6 defragmentation is used.
>
>The faulty commit is not essential for -stable, it only
>delays netns teardown for longer than needed when that netns
>still has ipv6 frags queued.  Much better than crash :-/
>
>commit ids are:
>4.4.y: not affected (not backported)
>4.9.y: backported as ad8b1ffc3efae2f65080bdb11145c87d299b8f9a
>4.14.y: backported as 28c74ff85efd192aeca9005499ca50c24d795f61
>4.18.y: (first affected kernel): 84379c9afe011020e797e3f50a662b08a6355dcf
>
>For 4.19.y, you could also wait for a bug fix to hit Linus tree,
>I can ping you again once its in:
>https://patchwork.ozlabs.org/patch/988233/

I've queued a revert for 4.18, 4.14, and 4.9. Thank you.

      reply	other threads:[~2018-10-31 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 10:31 stable regression: revert request for netfilter ipv6 defrag bug Florian Westphal
2018-10-31 15:07 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031150753.GR194472@sasha-vm \
    --to=sashal@kernel.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).