From: Michal Hocko <mhocko@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: Shakeel Butt <shakeelb@google.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com
Subject: Re: [PATCH] netfilter: account ebt_table_info to kmemcg
Date: Sat, 29 Dec 2018 11:06:15 +0100 [thread overview]
Message-ID: <20181229100615.GB16738@dhcp22.suse.cz> (raw)
In-Reply-To: <20181229095215.nbcijqacw5b6aho7@breakpoint.cc>
On Sat 29-12-18 10:52:15, Florian Westphal wrote:
> Michal Hocko <mhocko@kernel.org> wrote:
> > On Fri 28-12-18 17:55:24, Shakeel Butt wrote:
> > > The [ip,ip6,arp]_tables use x_tables_info internally and the underlying
> > > memory is already accounted to kmemcg. Do the same for ebtables. The
> > > syzbot, by using setsockopt(EBT_SO_SET_ENTRIES), was able to OOM the
> > > whole system from a restricted memcg, a potential DoS.
> >
> > What is the lifetime of these objects? Are they bound to any process?
>
> No, they are not.
> They are free'd only when userspace requests it or the netns is
> destroyed.
Then this is problematic, because the oom killer is not able to
guarantee the hard limit and so the excessive memory consumption cannot
be really contained. As a result the memcg will be basically useless
until somebody tears down the charged objects by other means. The memcg
oom killer will surely kill all the existing tasks in the cgroup and
this could somehow reduce the problem. Maybe this is sufficient for
some usecases but that should be properly analyzed and described in the
changelog.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-12-29 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 1:55 [PATCH] netfilter: account ebt_table_info to kmemcg Shakeel Butt
2018-12-29 7:33 ` Michal Hocko
2018-12-29 9:52 ` Florian Westphal
2018-12-29 10:06 ` Michal Hocko [this message]
2018-12-29 19:34 ` Shakeel Butt
2018-12-30 7:45 ` Michal Hocko
2018-12-30 8:00 ` Michal Hocko
2018-12-31 3:59 ` Shakeel Butt
2018-12-31 10:11 ` Michal Hocko
2019-01-03 20:52 ` Shakeel Butt
2019-01-04 13:21 ` Michal Hocko
2018-12-31 4:00 ` Shakeel Butt
2018-12-29 9:52 ` Kirill Tkhai
2018-12-29 19:39 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229100615.GB16738@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=roopa@cumulusnetworks.com \
--cc=shakeelb@google.com \
--cc=syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).