From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@ucloud.cn
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RESEND] nft_flow_offload: Fix the peer route get from wrong daddr
Date: Wed, 9 Jan 2019 20:06:37 +0100 [thread overview]
Message-ID: <20190109190637.rhqpp2edpikv3vng@salvia> (raw)
In-Reply-To: <20190109190358.o2asukctfbijhbqw@salvia>
On Wed, Jan 09, 2019 at 08:03:58PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Jan 09, 2019 at 10:40:11AM +0800, wenxu@ucloud.cn wrote:
> > From: wenxu <wenxu@ucloud.cn>
> >
> > For nat example:
> > client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server
> >
> > When syn_rcv pkt from server it get the peer(client->server) route
> > through daddr = ct->tuplehash[!dir].tuple.dst.u3.ip, the value 2.2.2.7
> > is not correct in this situation. it should be 10.0.0.7
> > ct->tuplehash[dir].tuple.src.u3.ip
>
> Patch is correct, applied, thanks.
BTW, let me rewrite patch title to:
netfilter: nft_flow_offload: Fix reverse route lookup
I'll also slightly revisit the patch description before applying.
Thanks.
prev parent reply other threads:[~2019-01-09 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 2:40 [PATCH RESEND] nft_flow_offload: Fix the peer route get from wrong daddr wenxu
2019-01-09 19:03 ` Pablo Neira Ayuso
2019-01-09 19:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109190637.rhqpp2edpikv3vng@salvia \
--to=pablo@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).