From: Michal Hocko <mhocko@kernel.org>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Florian Westphal <fw@strlen.de>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH v2] netfilter: account ebt_table_info to kmemcg
Date: Thu, 10 Jan 2019 10:41:42 +0100 [thread overview]
Message-ID: <20190110094142.GI31793@dhcp22.suse.cz> (raw)
In-Reply-To: <2d8f28cb-8620-be05-21bc-dcf3009b2774@virtuozzo.com>
On Thu 10-01-19 12:22:09, Kirill Tkhai wrote:
[...]
> >> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> >> index 491828713e0b..5e55cef0cec3 100644
> >> --- a/net/bridge/netfilter/ebtables.c
> >> +++ b/net/bridge/netfilter/ebtables.c
> >> @@ -1137,14 +1137,16 @@ static int do_replace(struct net *net, const void __user *user,
> >> tmp.name[sizeof(tmp.name) - 1] = 0;
> >>
> >> countersize = COUNTER_OFFSET(tmp.nentries) * nr_cpu_ids;
> >> - newinfo = vmalloc(sizeof(*newinfo) + countersize);
> >> + newinfo = __vmalloc(sizeof(*newinfo) + countersize, GFP_KERNEL_ACCOUNT,
> >> + PAGE_KERNEL);
>
> Do we need GFP_HIGHMEM here?
No. vmalloc adds __GPF_HIGHMEM implicitly (see __vmalloc_area_node).
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-10 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 3:14 [PATCH v2] netfilter: account ebt_table_info to kmemcg Shakeel Butt via Bridge
2019-01-03 10:14 ` William Kucharski
2019-01-03 16:18 ` Shakeel Butt
2019-01-06 11:00 ` Kirill Tkhai
2019-01-10 9:22 ` Kirill Tkhai
2019-01-10 9:41 ` Michal Hocko [this message]
2019-01-10 9:48 ` Kirill Tkhai
2019-01-10 0:44 ` Pablo Neira Ayuso
2019-01-10 23:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110094142.GI31793@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=roopa@cumulusnetworks.com \
--cc=shakeelb@google.com \
--cc=syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).