* [PATCH] xtables-legacy: add missing config.h include
@ 2019-03-08 14:37 Lucas Stach
2019-03-18 15:42 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2019-03-08 14:37 UTC (permalink / raw)
To: netfilter-devel
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
iptables/xtables-legacy-multi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/iptables/xtables-legacy-multi.c b/iptables/xtables-legacy-multi.c
index e68814dd082e..3b7905ff76b1 100644
--- a/iptables/xtables-legacy-multi.c
+++ b/iptables/xtables-legacy-multi.c
@@ -1,3 +1,4 @@
+#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xtables-legacy: add missing config.h include
2019-03-08 14:37 [PATCH] xtables-legacy: add missing config.h include Lucas Stach
@ 2019-03-18 15:42 ` Pablo Neira Ayuso
2019-03-19 15:16 ` Lucas Stach
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2019-03-18 15:42 UTC (permalink / raw)
To: Lucas Stach; +Cc: netfilter-devel
Hi Lucas,
I can blindly take this, since I guess you're fixing a problem there.
I guess it's a compilation issue with some specific toolchain? Because
I cannot reproduce this here.
Thanks!
On Fri, Mar 08, 2019 at 03:37:09PM +0100, Lucas Stach wrote:
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> iptables/xtables-legacy-multi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/iptables/xtables-legacy-multi.c b/iptables/xtables-legacy-multi.c
> index e68814dd082e..3b7905ff76b1 100644
> --- a/iptables/xtables-legacy-multi.c
> +++ b/iptables/xtables-legacy-multi.c
> @@ -1,3 +1,4 @@
> +#include <config.h>
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xtables-legacy: add missing config.h include
2019-03-18 15:42 ` Pablo Neira Ayuso
@ 2019-03-19 15:16 ` Lucas Stach
2019-04-03 18:10 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Lucas Stach @ 2019-03-19 15:16 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
Hi Pablo,
Am Montag, den 18.03.2019, 16:42 +0100 schrieb Pablo Neira Ayuso:
> Hi Lucas,
>
> I can blindly take this, since I guess you're fixing a problem there.
>
> I guess it's a compilation issue with some specific toolchain? Because
> I cannot reproduce this here.
This fixes a IPv4 only build, where this file would have references to
functions that aren't built in this case. I'm not sure how it ends up
with ENABLE_IPV6 defined without the config.h include, but since this
was clearly missing and fixed my issue, I didn't bother tracking down
the chain.
Regards,
Lucas
> Thanks!
>
> On Fri, Mar 08, 2019 at 03:37:09PM +0100, Lucas Stach wrote:
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > iptables/xtables-legacy-multi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/iptables/xtables-legacy-multi.c b/iptables/xtables-legacy-multi.c
> > index e68814dd082e..3b7905ff76b1 100644
> > --- a/iptables/xtables-legacy-multi.c
> > +++ b/iptables/xtables-legacy-multi.c
> > @@ -1,3 +1,4 @@
> > +#include <config.h>
> > #include <stdio.h>
> > #include <stdlib.h>
> > #include <string.h>
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xtables-legacy: add missing config.h include
2019-03-19 15:16 ` Lucas Stach
@ 2019-04-03 18:10 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2019-04-03 18:10 UTC (permalink / raw)
To: Lucas Stach; +Cc: netfilter-devel
On Tue, Mar 19, 2019 at 04:16:41PM +0100, Lucas Stach wrote:
> Hi Pablo,
>
> Am Montag, den 18.03.2019, 16:42 +0100 schrieb Pablo Neira Ayuso:
> > Hi Lucas,
> >
> > I can blindly take this, since I guess you're fixing a problem there.
> >
> > I guess it's a compilation issue with some specific toolchain? Because
> > I cannot reproduce this here.
>
> This fixes a IPv4 only build, where this file would have references to
> functions that aren't built in this case. I'm not sure how it ends up
> with ENABLE_IPV6 defined without the config.h include, but since this
> was clearly missing and fixed my issue, I didn't bother tracking down
> the chain.
Applied, thanks for explaining.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-03 18:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-08 14:37 [PATCH] xtables-legacy: add missing config.h include Lucas Stach
2019-03-18 15:42 ` Pablo Neira Ayuso
2019-03-19 15:16 ` Lucas Stach
2019-04-03 18:10 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).