From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B5EC43381 for ; Mon, 18 Mar 2019 12:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35F5B20857 for ; Mon, 18 Mar 2019 12:50:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="casgW2NG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbfCRMuY (ORCPT ); Mon, 18 Mar 2019 08:50:24 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46856 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbfCRMuY (ORCPT ); Mon, 18 Mar 2019 08:50:24 -0400 Received: by mail-pf1-f196.google.com with SMTP id s23so11171932pfe.13; Mon, 18 Mar 2019 05:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ns4e4/Rd6bF0R6chwH0zebqELDJAs3QtT0Rc73v8mYQ=; b=casgW2NG+y33l87eA1BfNyHh2BRhInT44+A8Ot3dVI+RxsiWAtVWZnleaa5JSxATg5 /lAiwADktoQg4fXJ/aHCs4xioHTOtyoFc+8BvenUkz+x78Jms9m5vKEaYeOZWsHluusd ixrfp6Ok2vWZQZO5V3Ifdl/WGZ9hsgK+WaSfb/ltdfmPqgj7aMkYtDQD1vH6HvVJLo1Y 9c2gfLXFxE9bSI/+Jw/DMy4ch5HMHii8MRwufGANY05P6JJrS+xStBLc9qBSvysZ9zEP aDmPVHh9NAl5bupLj+x16zXFWr5fc4d21FAy+8CVxmta+KLnlMa4K/zyJmm4tBPFVeEp m5WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ns4e4/Rd6bF0R6chwH0zebqELDJAs3QtT0Rc73v8mYQ=; b=dFNm6HZycgcCkvzjqvhjo9nMYCnsamCT/uz01WhudVegCbULGg3Ur/KkaIcmVYhbY1 HP5qq/r+oZBJzRTW7911cN+Xvgh5L1tm80EwkU++ukXk2pQPTHwaDxEIUqs4M0o9xo+w xBxa1sityCyDs4kDzUhBHiLH2+3UcblEbnUqFtOlyQv4DtT2XC5AW9G0Je/Gj73MPLnX Z8b1h+70/aXCizG/ak8J0jRVPU8XkqXUPV+oyD0L6hmNN9c7GDNroQj1WUHTCrLErQk1 IyxwvOUu37JJ0RuE263qlDhhvGuWX0VSCMe7IT2GxorpCB6rXyXM4x6LeqLdeSm9JzW1 l6aQ== X-Gm-Message-State: APjAAAUyNOcxEkmCCaUB7k2CAnAS+AQqz5Yp9zfgEckWP1FZ3keJHPYX kwAR0zIHXdmu43i+2SOIUA== X-Google-Smtp-Source: APXvYqw4Xhfq1MZYOJP+VTR01Dty/7tC6ktY5Pt7a70r1Q8FCgIc5xtD3XaX4pvazj+WDjYrotJKTg== X-Received: by 2002:a63:2d5:: with SMTP id 204mr17023227pgc.407.1552913423041; Mon, 18 Mar 2019 05:50:23 -0700 (PDT) Received: from localhost ([2001:19f0:7001:54c5:5400:1ff:fec8:7fc2]) by smtp.gmail.com with ESMTPSA id l187sm13347980pgl.75.2019.03.18.05.50.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 05:50:21 -0700 (PDT) Date: Mon, 18 Mar 2019 20:50:18 +0800 From: Jacky Hu To: Julian Anastasov Cc: kbuild test robot , kbuild-all@01.org, jacky.hu@walmart.com, jason.niesz@walmart.com, Wensong Zhang , Simon Horman , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH v4] ipvs: allow tunneling with gue encapsulation Message-ID: <20190318125018.GA4499@i716> References: <20190317155200.16586-1-hengqing.hu@gmail.com> <201903181001.7czsRhlB%lkp@intel.com> <20190318032256.GA21124@i716> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hello, On Mon, Mar 18, 2019 at 10:14:20AM +0200, Julian Anastasov wrote: > > Hello, > > On Mon, 18 Mar 2019, Jacky Hu wrote: > > > On Mon, Mar 18, 2019 at 10:10:20AM +0800, kbuild test robot wrote: > > > Hi Jacky, > > > > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on ipvs-next/master] > > > [also build test WARNING on v5.1-rc1 next-20190306] > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > > > > > url: https://github.com/0day-ci/linux/commits/Jacky-Hu/ipvs-allow-tunneling-with-gue-encapsulation/20190318-070156 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master > > > reproduce: > > > # apt-get install sparse > > > make ARCH=x86_64 allmodconfig > > > make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' > > > > > > > > > sparse warnings: (new ones prefixed by >>) > > > > > > net/netfilter/ipvs/ip_vs_ctl.c:835:42: sparse: incorrect type in argument 2 (different base types) @@ expected int [signed] i @@ got restricted __be1int [signed] i @@ > > > net/netfilter/ipvs/ip_vs_ctl.c:835:42: expected int [signed] i > > > net/netfilter/ipvs/ip_vs_ctl.c:835:42: got restricted __be16 [usertype] tun_port > > > net/netfilter/ipvs/ip_vs_ctl.c:1197:44: sparse: expression using sizeof(void) > > > >> net/netfilter/ipvs/ip_vs_ctl.c:3207:37: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be16 [usertype] value @@ got e] value @@ > > > net/netfilter/ipvs/ip_vs_ctl.c:3207:37: expected restricted __be16 [usertype] value > > > net/netfilter/ipvs/ip_vs_ctl.c:3207:37: got int > > > net/netfilter/ipvs/ip_vs_ctl.c:1313:27: sparse: dereference of noderef expression > > > > > > vim +3207 net/netfilter/ipvs/ip_vs_ctl.c > > > > > > > > 3207 atomic_read(&dest->tun_port)) || > > > > Should I change the type of tun_port from __be16 to u16? > > Looks like kbuild bugs a lot on this. > > In struct ip_vs_dest you should use __be16 for tun_port and > __u16 for tun_type and avoid any atomic_t usage. To test it with sparse: > > make C=2 CF="-D__CHECK_ENDIAN__" net/netfilter/ipvs/ > > And this is the only problem in v4 of the patch. Then may be > you should wait when net-next opens again before submitting v5. > > Regards > > -- > Julian Anastasov I have made the required changes locally, also updated ipvsadm accordingly, once it opens, I'll submit them. Thanks. Best Regards, Jacky