From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de, eric.dumazet@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: [PATCH net-next,RFC 1/8] net: use kfree_skb_list() from ip_do_fragment()
Date: Wed, 3 Apr 2019 17:39:54 +0200 [thread overview]
Message-ID: <20190403154001.8177-2-pablo@netfilter.org> (raw)
In-Reply-To: <20190403154001.8177-1-pablo@netfilter.org>
Just like 46cfd725c377 ("net: use kfree_skb_list() helper in more places").
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/ipv4/ip_output.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index c80188875f39..10b35328cfbc 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -693,11 +693,8 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
return 0;
}
- while (frag) {
- skb = frag->next;
- kfree_skb(frag);
- frag = skb;
- }
+ kfree_skb_list(frag);
+
IP_INC_STATS(net, IPSTATS_MIB_FRAGFAILS);
return err;
--
2.11.0
next prev parent reply other threads:[~2019-04-03 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 15:39 [PATCH net-next,RFC 0/8] connection tracking support for bridge Pablo Neira Ayuso
2019-04-03 15:39 ` Pablo Neira Ayuso [this message]
2019-04-04 10:13 ` [PATCH net-next,RFC 1/8] net: use kfree_skb_list() from ip_do_fragment() Florian Westphal
2019-04-03 15:39 ` [PATCH net-next,RFC 2/8] net: ipv4: add skbuff fraglist split iterator Pablo Neira Ayuso
2019-04-03 15:39 ` [PATCH net-next,RFC 3/8] net: ipv6: " Pablo Neira Ayuso
2019-04-03 15:39 ` [PATCH net-next,RFC 4/8] net: ipv4: split skbuff into fragments transformer Pablo Neira Ayuso
2019-04-03 15:39 ` [PATCH net-next,RFC 5/8] net: ipv6: " Pablo Neira Ayuso
2019-04-03 15:39 ` [PATCH net-next,RFC 6/8] net: ipv4: place cb handling away from fraglist iterator Pablo Neira Ayuso
2019-04-03 15:40 ` [PATCH net-next,RFC 7/8] net: ipv4: place cb handling away from fragment transformer Pablo Neira Ayuso
2019-04-03 15:40 ` [PATCH net-next,RFC 8/8] netfilter: bridge: add basic conntrack support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403154001.8177-2-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).