From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3327FC43218 for ; Fri, 26 Apr 2019 00:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 143A5206C1 for ; Fri, 26 Apr 2019 00:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730266AbfDZAed (ORCPT ); Thu, 25 Apr 2019 20:34:33 -0400 Received: from mail.us.es ([193.147.175.20]:55210 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729734AbfDZAeA (ORCPT ); Thu, 25 Apr 2019 20:34:00 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 5499BB4991 for ; Fri, 26 Apr 2019 02:33:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 47346DA705 for ; Fri, 26 Apr 2019 02:33:59 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 34D06DA702; Fri, 26 Apr 2019 02:33:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 22E64DA702; Fri, 26 Apr 2019 02:33:57 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 26 Apr 2019 02:33:57 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from salvia.here (sys.soleta.eu [212.170.55.40]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id BFA474265A31; Fri, 26 Apr 2019 02:33:56 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@mellanox.com, john.hurley@netronome.com, jakub.kicinski@netronome.com, ogerlitz@mellanox.com Subject: [PATCH net-next,RFC 2/9] net: sched: add tcf_block_cb_alloc() Date: Fri, 26 Apr 2019 02:33:39 +0200 Message-Id: <20190426003348.30745-3-pablo@netfilter.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190426003348.30745-1-pablo@netfilter.org> References: <20190426003348.30745-1-pablo@netfilter.org> X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Add a new helper function to allocate tcf_block_cb objects. Signed-off-by: Pablo Neira Ayuso --- include/net/pkt_cls.h | 2 ++ net/sched/cls_api.c | 23 +++++++++++++++++++---- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index d5e7a1af346f..8ddfbe94e253 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -71,6 +71,8 @@ static inline struct Qdisc *tcf_block_q(struct tcf_block *block) return block->q; } +struct tcf_block_cb *tcf_block_cb_alloc(tc_setup_cb_t *cb, + void *cb_ident, void *cb_priv); void *tcf_block_cb_priv(struct tcf_block_cb *block_cb); struct tcf_block_cb *tcf_block_cb_lookup(struct tcf_block *block, tc_setup_cb_t *cb, void *cb_ident); diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 71ec0a34100d..ddfccf31aac9 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -749,6 +749,23 @@ unsigned int tcf_block_cb_decref(struct tcf_block_cb *block_cb) } EXPORT_SYMBOL(tcf_block_cb_decref); +struct tcf_block_cb *tcf_block_cb_alloc(tc_setup_cb_t *cb, + void *cb_ident, void *cb_priv) +{ + struct tcf_block_cb *block_cb; + + block_cb = kzalloc(sizeof(*block_cb), GFP_KERNEL); + if (!block_cb) + return NULL; + + block_cb->cb = cb; + block_cb->cb_ident = cb_ident; + block_cb->cb_priv = cb_priv; + + return block_cb; +} +EXPORT_SYMBOL(tcf_block_cb_alloc); + struct tcf_block_cb *__tcf_block_cb_register(struct tcf_block *block, tc_setup_cb_t *cb, void *cb_ident, void *cb_priv, @@ -764,12 +781,10 @@ struct tcf_block_cb *__tcf_block_cb_register(struct tcf_block *block, if (err) return ERR_PTR(err); - block_cb = kzalloc(sizeof(*block_cb), GFP_KERNEL); + block_cb = tcf_block_cb_alloc(cb, cb_ident, cb_priv); if (!block_cb) return ERR_PTR(-ENOMEM); - block_cb->cb = cb; - block_cb->cb_ident = cb_ident; - block_cb->cb_priv = cb_priv; + list_add(&block_cb->list, &block->cb_list); return block_cb; } -- 2.11.0