netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Garver <eric@garver.life>
To: netfilter-devel@vger.kernel.org
Cc: Phil Sutter <phil@nwl.cc>
Subject: [PATCH nft] py: fix missing decode/encode of strings
Date: Wed,  1 May 2019 12:35:00 -0400	[thread overview]
Message-ID: <20190501163500.29662-1-eric@garver.life> (raw)

When calling ffi functions we need to convert from python strings to
utf-8. Then convert back for any output we receive.

Fixes: 586ad210368b7 ("libnftables: Implement JSON parser")
Signed-off-by: Eric Garver <eric@garver.life>
---
 py/nftables.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/py/nftables.py b/py/nftables.py
index f07163573f9a..dea417e587d6 100644
--- a/py/nftables.py
+++ b/py/nftables.py
@@ -352,9 +352,9 @@ class Nftables:
         output -- a string containing output written to stdout
         error  -- a string containing output written to stderr
         """
-        rc = self.nft_run_cmd_from_buffer(self.__ctx, cmdline)
-        output = self.nft_ctx_get_output_buffer(self.__ctx)
-        error = self.nft_ctx_get_error_buffer(self.__ctx)
+        rc = self.nft_run_cmd_from_buffer(self.__ctx, cmdline.encode("utf-8"))
+        output = self.nft_ctx_get_output_buffer(self.__ctx).decode("utf-8")
+        error = self.nft_ctx_get_error_buffer(self.__ctx).decode("utf-8")
 
         return (rc, output, error)
 
-- 
2.20.1


             reply	other threads:[~2019-05-01 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01 16:35 Eric Garver [this message]
2019-05-03 15:51 ` [PATCH nft] py: fix missing decode/encode of strings Phil Sutter
2019-05-03 17:20   ` Eric Garver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501163500.29662-1-eric@garver.life \
    --to=eric@garver.life \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).