From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: [PATCH nf] netfilter: ebtables: CONFIG_COMPAT: reject trailing data after last rule
Date: Thu, 9 May 2019 08:54:14 +0200 [thread overview]
Message-ID: <20190509065414.tdb7ienlv7zkyib3@salvia> (raw)
In-Reply-To: <20190505164733.31905-1-fw@strlen.de>
On Sun, May 05, 2019 at 06:47:33PM +0200, Florian Westphal wrote:
> If userspace provides a rule blob with trailing data after last target,
> we trigger a splat, then convert ruleset to 64bit format (with trailing
> data), then pass that to do_replace_finish() which then returns -EINVAL.
>
> Erroring out right away avoids the splat plus unneeded translation and
> error unwind,
Applied, thanks Florian.
prev parent reply other threads:[~2019-05-09 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 16:47 [PATCH nf] netfilter: ebtables: CONFIG_COMPAT: reject trailing data after last rule Florian Westphal
2019-05-09 6:54 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509065414.tdb7ienlv7zkyib3@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).