From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Stéphane Veyret" <sveyret@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nft_ct: add ct expectations support
Date: Mon, 13 May 2019 10:37:22 +0200 [thread overview]
Message-ID: <20190513083722.c45swifrfdlaptbc@salvia> (raw)
In-Reply-To: <CAFs+hh6emDCoyuE_KpxX_2U5kFT=q3CwUUp_dB887Grq8Lcf5g@mail.gmail.com>
On Mon, May 13, 2019 at 08:00:53AM +0200, Stéphane Veyret wrote:
> Le dim. 12 mai 2019 à 19:56, Pablo Neira Ayuso <pablo@netfilter.org> a écrit :
> >
> > > But I actually saw today that these values are used in the « nftables
> > > » project. There is a copy of nf_tables.h there. Not sure it is a good
> > > idea to keep the variables in « nftables » and not in kernel.
> >
> > I have just updated the cached copy of nf_tables.h in
> > git.netfilter.org:
>
> So now nftables does not compile anymore, does it? What do you think
> we should do, then? Add a new variable, out of nf_tables.h, in
> nftables project?
Please, do not add a new enumeration definition to nf_tables.h for
something we do not need in UAPI.
Thanks.
next prev parent reply other threads:[~2019-05-13 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 15:40 [PATCH] netfilter: nft_ct: add ct expectations support Stéphane Veyret
2019-05-05 15:58 ` Florian Westphal
2019-05-05 22:51 ` Pablo Neira Ayuso
2019-05-10 16:00 ` [PATCH nf-next,v2] " Stéphane Veyret
2019-05-11 18:54 ` [PATCH] " Stéphane Veyret
2019-05-12 17:56 ` Pablo Neira Ayuso
2019-05-13 6:00 ` Stéphane Veyret
2019-05-13 8:37 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-04 17:35 Stéphane Veyret
2019-05-05 13:24 ` Jeremy Sowden
2019-05-05 15:38 ` Stéphane Veyret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513083722.c45swifrfdlaptbc@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sveyret@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).