From: Phil Sutter <phil@nwl.cc>
To: Shekhar Sharma <shekhar250198@gmail.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v3]tests: py: add netns feature
Date: Tue, 28 May 2019 18:14:46 +0200 [thread overview]
Message-ID: <20190528161446.GD21440@orbyte.nwl.cc> (raw)
In-Reply-To: <20190528160917.GC21440@orbyte.nwl.cc>
On Tue, May 28, 2019 at 06:09:17PM +0200, Phil Sutter wrote:
> Hi,
>
> On Tue, May 28, 2019 at 05:51:13AM +0530, Shekhar Sharma wrote:
> > This patch adds the netns feature to the 'nft-test.py' file.
>
> This patch does more than that. It seems you've mixed the netns support
> enhancement with Python3 compatibility enablement. Could you please
> split these into two patches for easier review? Being able to clearly
> see what has been done to enable netns support will be helpful later
> when scrolling through git history, too.
Oh, I shouldn't read my INBOX in reverse. I see you submitted a first
patch containing the Python3 stuff only. Please read up on creating,
maintaining and submitting patch series using git - these are precious
tools you won't want to miss once acquired. :)
Cheers, Phil
next prev parent reply other threads:[~2019-05-28 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 0:21 [PATCH nft v3]tests: py: add netns feature Shekhar Sharma
2019-05-28 16:09 ` Phil Sutter
2019-05-28 16:14 ` Phil Sutter [this message]
2019-05-28 16:15 ` shekhar sharma
2019-05-28 16:16 ` shekhar sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528161446.GD21440@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=shekhar250198@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).