From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55DC1C31E49 for ; Wed, 19 Jun 2019 10:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F08F2080C for ; Wed, 19 Jun 2019 10:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731483AbfFSKv2 (ORCPT ); Wed, 19 Jun 2019 06:51:28 -0400 Received: from mail.us.es ([193.147.175.20]:40976 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727548AbfFSKv2 (ORCPT ); Wed, 19 Jun 2019 06:51:28 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D6A8367B9F for ; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C6B3DDA720 for ; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id C3919DA781; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5515BDA718; Wed, 19 Jun 2019 12:51:23 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 19 Jun 2019 12:51:23 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 1D9474265A32; Wed, 19 Jun 2019 12:51:23 +0200 (CEST) Date: Wed, 19 Jun 2019 12:51:22 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2][next] netfilter: synproxy: ensure zero is returned on non-error return path Message-ID: <20190619105122.envwm53ew7isp4m2@salvia> References: <20190618142244.16463-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618142244.16463-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jun 18, 2019 at 03:22:44PM +0100, Colin King wrote: > From: Colin Ian King > > Currently functions nf_synproxy_{ipc4|ipv6}_init return an uninitialized > garbage value in variable ret on a successful return. Fix this by > returning zero on success. Applied, thanks Colin.