* [PATCH nft] tests: py: use tempfile module
@ 2019-06-19 13:38 Eric Garver
2019-06-27 12:36 ` Eric Garver
0 siblings, 1 reply; 2+ messages in thread
From: Eric Garver @ 2019-06-19 13:38 UTC (permalink / raw)
To: Pablo Neira Ayuso, shekhar sharma; +Cc: netfilter-devel
os.tmpfile() is not in python3.
Signed-off-by: Eric Garver <eric@garver.life>
---
tests/py/nft-test.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py
index f80517e67bfd..4da6fa650f6d 100755
--- a/tests/py/nft-test.py
+++ b/tests/py/nft-test.py
@@ -20,6 +20,7 @@ import argparse
import signal
import json
import traceback
+import tempfile
TESTS_PATH = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, os.path.join(TESTS_PATH, '../../py/'))
@@ -771,7 +772,7 @@ def rule_add(rule, filename, lineno, force_all_family_option, filename_path):
unit_tests += 1
table_flush(table, filename, lineno)
- payload_log = os.tmpfile()
+ payload_log = tempfile.TemporaryFile(mode="w+")
# Add rule and check return code
cmd = "add rule %s %s %s" % (table, chain, rule[0])
@@ -911,7 +912,7 @@ def rule_add(rule, filename, lineno, force_all_family_option, filename_path):
gotf.name, 1)
table_flush(table, filename, lineno)
- payload_log = os.tmpfile()
+ payload_log = tempfile.TemporaryFile(mode="w+")
# Add rule in JSON format
cmd = json.dumps({ "nftables": [{ "add": { "rule": {
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nft] tests: py: use tempfile module
2019-06-19 13:38 [PATCH nft] tests: py: use tempfile module Eric Garver
@ 2019-06-27 12:36 ` Eric Garver
0 siblings, 0 replies; 2+ messages in thread
From: Eric Garver @ 2019-06-27 12:36 UTC (permalink / raw)
To: Pablo Neira Ayuso, shekhar sharma; +Cc: netfilter-devel
On Wed, Jun 19, 2019 at 09:38:42AM -0400, Eric Garver wrote:
> os.tmpfile() is not in python3.
>
> Signed-off-by: Eric Garver <eric@garver.life>
> ---
Pablo,
Shekhar included this change in patch "[PATCH nft v9]tests: py: fix
pyhton3". So this patch can be dropped.
Thanks.
Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-27 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 13:38 [PATCH nft] tests: py: use tempfile module Eric Garver
2019-06-27 12:36 ` Eric Garver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).