Re: [PATCH libnftnl v2] src: libnftnl: add support for matching IPv4 options

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Jun 20, 2019 at 07:54:29AM -0400, Stephen Suryaputra wrote:
[...]
> diff --git a/src/expr/exthdr.c b/src/expr/exthdr.c
> index bef453e..e5f714b 100644
> --- a/src/expr/exthdr.c
> +++ b/src/expr/exthdr.c
> @@ -200,6 +200,9 @@ static const char *op2str(uint8_t op)
>  	case NFT_EXTHDR_OP_TCPOPT:
>  		return " tcpopt";
>  	case NFT_EXTHDR_OP_IPV6:
> +		return " ipv6";
> +	case NFT_EXTHDR_OP_IPV4:
> +		return " ipv4";
>  	default:
>  		return "";
>  	}

Would you mind to install libnftnl with this patch on top and run:

nftables/tests/py/# python nft-tests.py

to check if this breaks testcases, if so a patch to update tests in
nftables would be great too.

Thanks!

> @@ -209,6 +212,8 @@ static inline int str2exthdr_op(const char* str)
>  {
>  	if (!strcmp(str, "tcpopt"))
>  		return NFT_EXTHDR_OP_TCPOPT;
> +	if (!strcmp(str, "ipv4"))
> +		return NFT_EXTHDR_OP_IPV4;
>  
>  	/* if str == "ipv6" or anything else */
>  	return NFT_EXTHDR_OP_IPV6;
> -- 
> 2.17.1
>