From: Florian Westphal <fw@strlen.de>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 1/3] nft: use own allocation function
Date: Thu, 27 Jun 2019 13:20:26 +0200 [thread overview]
Message-ID: <20190627112026.vbvmz7j3dmz5pdvm@breakpoint.cc> (raw)
In-Reply-To: <156163260014.22035.13586288868224137755.stgit@endurance>
Arturo Borrero Gonzalez <arturo@netfilter.org> wrote:
> In the current setup, nft (the frontend object) is using the xzalloc() function
> from libnftables, which does not makes sense, as this is typically an internal
> helper function.
>
> In order to don't use this public libnftables symbol (a later patch just
> removes it), let's introduce a new allocation function in the nft frontend.
> This results in a bit of code duplication, but given the simplicity of the code,
> I don't think it's a big deal.
>
> Other possible approach would be to have xzalloc() become part of libnftables
> public API, but that is a much worse scenario I think.
Agree, thus:
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-06-27 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 10:50 [nft PATCH 1/3] nft: use own allocation function Arturo Borrero Gonzalez
2019-06-27 10:50 ` [nft PATCH 2/3] libnftables: reallocate definition of nft_print() and nft_gmp_print() Arturo Borrero Gonzalez
2019-06-27 10:59 ` Arturo Borrero Gonzalez
2019-06-27 11:22 ` Florian Westphal
2019-06-27 12:20 ` Pablo Neira Ayuso
2019-06-27 10:50 ` [nft PATCH 3/3] libnftables: export public symbols only Arturo Borrero Gonzalez
2019-06-27 11:21 ` Florian Westphal
2019-06-27 11:20 ` Florian Westphal [this message]
2019-06-27 12:19 ` [nft PATCH 1/3] nft: use own allocation function Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627112026.vbvmz7j3dmz5pdvm@breakpoint.cc \
--to=fw@strlen.de \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).