From: Phil Sutter <phil@nwl.cc>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2 1/3] nft: don't use xzalloc()
Date: Thu, 4 Jul 2019 12:21:23 +0200 [thread overview]
Message-ID: <20190704102123.GA20778@orbyte.nwl.cc> (raw)
In-Reply-To: <156197834773.14440.15033673835278456059.stgit@endurance>
Hi Arturo,
On Mon, Jul 01, 2019 at 12:52:48PM +0200, Arturo Borrero Gonzalez wrote:
> In the current setup, nft (the frontend object) is using the xzalloc() function
> from libnftables, which does not makes sense, as this is typically an internal
> helper function.
>
> In order to don't use this public libnftables symbol (a later patch just
> removes it), let's use calloc() directly in the nft frontend.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
This series breaks builds for me. Seems you missed xfree() and xmalloc()
used in src/main.c and src/cli.c.
Cheers, Phil
next prev parent reply other threads:[~2019-07-04 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 10:52 [nft PATCH v2 1/3] nft: don't use xzalloc() Arturo Borrero Gonzalez
2019-07-01 10:53 ` [nft PATCH v2 2/3] libnftables: reallocate definition of nft_print() and nft_gmp_print() Arturo Borrero Gonzalez
2019-07-01 18:25 ` Pablo Neira Ayuso
2019-07-01 10:53 ` [nft PATCH v2 3/3] libnftables: export public symbols only Arturo Borrero Gonzalez
2019-07-01 18:25 ` Pablo Neira Ayuso
2019-07-01 18:23 ` [nft PATCH v2 1/3] nft: don't use xzalloc() Pablo Neira Ayuso
2019-07-04 10:21 ` Phil Sutter [this message]
2019-07-04 12:41 ` Pablo Neira Ayuso
2019-07-04 14:43 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704102123.GA20778@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).