From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96A1C06513 for ; Thu, 4 Jul 2019 10:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A80E5218A0 for ; Thu, 4 Jul 2019 10:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727488AbfGDKVZ (ORCPT ); Thu, 4 Jul 2019 06:21:25 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:48272 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727303AbfGDKVZ (ORCPT ); Thu, 4 Jul 2019 06:21:25 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1hiyrj-0004hC-6K; Thu, 04 Jul 2019 12:21:23 +0200 Date: Thu, 4 Jul 2019 12:21:23 +0200 From: Phil Sutter To: Arturo Borrero Gonzalez Cc: netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH v2 1/3] nft: don't use xzalloc() Message-ID: <20190704102123.GA20778@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Arturo Borrero Gonzalez , netfilter-devel@vger.kernel.org References: <156197834773.14440.15033673835278456059.stgit@endurance> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156197834773.14440.15033673835278456059.stgit@endurance> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Arturo, On Mon, Jul 01, 2019 at 12:52:48PM +0200, Arturo Borrero Gonzalez wrote: > In the current setup, nft (the frontend object) is using the xzalloc() function > from libnftables, which does not makes sense, as this is typically an internal > helper function. > > In order to don't use this public libnftables symbol (a later patch just > removes it), let's use calloc() directly in the nft frontend. > > Signed-off-by: Arturo Borrero Gonzalez This series breaks builds for me. Seems you missed xfree() and xmalloc() used in src/main.c and src/cli.c. Cheers, Phil