netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
	NetFilter <netfilter-devel@vger.kernel.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	wenxu <wenxu@ucloud.cn>
Subject: Re: linux-next: build failure after merge of the netfilter-next tree
Date: Tue, 9 Jul 2019 13:59:47 +1000	[thread overview]
Message-ID: <20190709135947.225603dc@canb.auug.org.au> (raw)
In-Reply-To: <20190708133958.6a30f5cb@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 7676 bytes --]

Hi all,

On Mon, 8 Jul 2019 13:39:58 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the netfilter-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from <command-line>:
> include/net/netfilter/nft_meta.h:6:21: warning: 'key' is narrower than values of its type
>   enum nft_meta_keys key:8;
>                      ^~~
> include/net/netfilter/nft_meta.h:6:21: error: field 'key' has incomplete type
> include/net/netfilter/nft_meta.h:8:22: warning: 'dreg' is narrower than values of its type
>    enum nft_registers dreg:8;
>                       ^~~~
> include/net/netfilter/nft_meta.h:8:22: error: field 'dreg' has incomplete type
> include/net/netfilter/nft_meta.h:9:22: warning: 'sreg' is narrower than values of its type
>    enum nft_registers sreg:8;
>                       ^~~~
> include/net/netfilter/nft_meta.h:9:22: error: field 'sreg' has incomplete type
> include/net/netfilter/nft_meta.h:13:32: error: array type has incomplete element type 'struct nla_policy'
>  extern const struct nla_policy nft_meta_policy[];
>                                 ^~~~~~~~~~~~~~~
> include/net/netfilter/nft_meta.h:17:22: warning: 'struct nlattr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nlattr * const tb[]);
>                       ^~~~~~
> include/net/netfilter/nft_meta.h:16:22: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nft_expr *expr,
>                       ^~~~~~~~
> include/net/netfilter/nft_meta.h:15:36: warning: 'struct nft_ctx' declared inside parameter list will not be visible outside of this definition or declaration
>  int nft_meta_get_init(const struct nft_ctx *ctx,
>                                     ^~~~~~~
> include/net/netfilter/nft_meta.h:21:22: warning: 'struct nlattr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nlattr * const tb[]);
>                       ^~~~~~
> include/net/netfilter/nft_meta.h:20:22: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nft_expr *expr,
>                       ^~~~~~~~
> include/net/netfilter/nft_meta.h:19:36: warning: 'struct nft_ctx' declared inside parameter list will not be visible outside of this definition or declaration
>  int nft_meta_set_init(const struct nft_ctx *ctx,
>                                     ^~~~~~~
> include/net/netfilter/nft_meta.h:24:22: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nft_expr *expr);
>                       ^~~~~~~~
> include/net/netfilter/nft_meta.h:23:30: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
>  int nft_meta_get_dump(struct sk_buff *skb,
>                               ^~~~~~~
> include/net/netfilter/nft_meta.h:27:22: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>          const struct nft_expr *expr);
>                       ^~~~~~~~
> include/net/netfilter/nft_meta.h:26:30: warning: 'struct sk_buff' declared inside parameter list will not be visible outside of this definition or declaration
>  int nft_meta_set_dump(struct sk_buff *skb,
>                               ^~~~~~~
> include/net/netfilter/nft_meta.h:31:23: warning: 'struct nft_pktinfo' declared inside parameter list will not be visible outside of this definition or declaration
>           const struct nft_pktinfo *pkt);
>                        ^~~~~~~~~~~
> include/net/netfilter/nft_meta.h:30:17: warning: 'struct nft_regs' declared inside parameter list will not be visible outside of this definition or declaration
>           struct nft_regs *regs,
>                  ^~~~~~~~
> include/net/netfilter/nft_meta.h:29:37: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>  void nft_meta_get_eval(const struct nft_expr *expr,
>                                      ^~~~~~~~
> include/net/netfilter/nft_meta.h:35:23: warning: 'struct nft_pktinfo' declared inside parameter list will not be visible outside of this definition or declaration
>           const struct nft_pktinfo *pkt);
>                        ^~~~~~~~~~~
> include/net/netfilter/nft_meta.h:34:17: warning: 'struct nft_regs' declared inside parameter list will not be visible outside of this definition or declaration
>           struct nft_regs *regs,
>                  ^~~~~~~~
> include/net/netfilter/nft_meta.h:33:37: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>  void nft_meta_set_eval(const struct nft_expr *expr,
>                                      ^~~~~~~~
> include/net/netfilter/nft_meta.h:38:19: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>       const struct nft_expr *expr);
>                    ^~~~~~~~
> include/net/netfilter/nft_meta.h:37:40: warning: 'struct nft_ctx' declared inside parameter list will not be visible outside of this definition or declaration
>  void nft_meta_set_destroy(const struct nft_ctx *ctx,
>                                         ^~~~~~~
> include/net/netfilter/nft_meta.h:42:19: warning: 'struct nft_data' declared inside parameter list will not be visible outside of this definition or declaration
>       const struct nft_data **data);
>                    ^~~~~~~~
> include/net/netfilter/nft_meta.h:41:19: warning: 'struct nft_expr' declared inside parameter list will not be visible outside of this definition or declaration
>       const struct nft_expr *expr,
>                    ^~~~~~~~
> include/net/netfilter/nft_meta.h:40:40: warning: 'struct nft_ctx' declared inside parameter list will not be visible outside of this definition or declaration
>  int nft_meta_set_validate(const struct nft_ctx *ctx,
>                                         ^~~~~~~
> 
> Caused by commit
> 
>   30e103fe24de ("netfilter: nft_meta: move bridge meta keys into nft_meta_bridge")
> 
> interacting with commit
> 
>   3a768d9f7ae5 ("kbuild: compile-test kernel headers to ensure they are self-contained")
> 
> from the kbuild tree.
> 
> I have applied the following patch for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 8 Jul 2019 13:34:42 +1000
> Subject: [PATCH] don't test build another netfilter header
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/Kbuild | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/Kbuild b/include/Kbuild
> index 78434c59701f..cfd73c94d015 100644
> --- a/include/Kbuild
> +++ b/include/Kbuild
> @@ -900,6 +900,7 @@ header-test-			+= net/netfilter/nf_tables_core.h
>  header-test-			+= net/netfilter/nf_tables_ipv4.h
>  header-test-			+= net/netfilter/nf_tables_ipv6.h
>  header-test-			+= net/netfilter/nft_fib.h
> +header-test-			+= net/netfilter/nft_meta.h
>  header-test-			+= net/netfilter/nft_reject.h
>  header-test-			+= net/netns/can.h
>  header-test-			+= net/netns/generic.h

I reported this yesterday against the netflter-next tree, but now the
fix patch is needed in the merge of the net-next tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-07-09  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08  3:39 linux-next: build failure after merge of the netfilter-next tree Stephen Rothwell
2019-07-09  3:59 ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-06-20 13:47 Stephen Rothwell
2019-06-20 13:57 ` Pablo Neira Ayuso
2019-06-20 14:16   ` Stephen Rothwell
2019-04-12  6:37 Stephen Rothwell
2019-04-12  8:15 ` Florian Westphal
2019-04-13  4:05   ` Stephen Rothwell
2019-04-12 16:36 ` Pablo Neira Ayuso
2019-02-13  5:54 Stephen Rothwell
2019-01-20 23:36 Stephen Rothwell
2018-10-15 23:41 Stephen Rothwell
2018-10-16  8:02 ` Pablo Neira Ayuso
2018-07-18  1:50 Stephen Rothwell
2016-08-18  1:56 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709135947.225603dc@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wenxu@ucloud.cn \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).