From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5670C742A2 for ; Thu, 11 Jul 2019 21:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82E2F21019 for ; Thu, 11 Jul 2019 21:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728566AbfGKVnm (ORCPT ); Thu, 11 Jul 2019 17:43:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbfGKVnm (ORCPT ); Thu, 11 Jul 2019 17:43:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8F41314DB02C0; Thu, 11 Jul 2019 14:43:41 -0700 (PDT) Date: Thu, 11 Jul 2019 14:43:41 -0700 (PDT) Message-Id: <20190711.144341.734081163012422910.davem@davemloft.net> To: xingwu.yang@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] ipv6: Use ipv6_authlen for len From: David Miller In-Reply-To: <20190710131410.75825-1-xingwu.yang@gmail.com> References: <20190710131410.75825-1-xingwu.yang@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 11 Jul 2019 14:43:41 -0700 (PDT) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: yangxingwu Date: Wed, 10 Jul 2019 21:14:10 +0800 > The length of AH header is computed manually as (hp->hdrlen+2)<<2. > However, in include/linux/ipv6.h, a macro named ipv6_authlen is > already defined for exactly the same job. This commit replaces > the manual computation code with the macro. > > Signed-off-by: yangxingwu Applied.