From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_tables: don't fail when updating base chain policy
Date: Tue, 16 Jul 2019 13:23:47 +0200 [thread overview]
Message-ID: <20190716112347.xvyucevt4bhbebc5@salvia> (raw)
In-Reply-To: <20190713215921.18696-1-fw@strlen.de>
On Sat, Jul 13, 2019 at 11:59:21PM +0200, Florian Westphal wrote:
> The following nftables test case fails on nf-next:
>
> tests/shell/run-tests.sh tests/shell/testcases/transactions/0011chain_0
>
> The test case contains:
> add chain x y { type filter hook input priority 0; }
> add chain x y { policy drop; }"
>
> The new test
> if (chain->flags ^ flags)
> return -EOPNOTSUPP;
>
> triggers here, because chain->flags has NFT_BASE_CHAIN set, but flags
> is 0 because no flag attribute was present in the policy update.
>
> Just fetch the current flag settings of a pre-existing chain in case
> userspace did not provide any.
Applied, thanks for fixing up this, this is my fault.
prev parent reply other threads:[~2019-07-16 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 21:59 [PATCH nf] netfilter: nf_tables: don't fail when updating base chain policy Florian Westphal
2019-07-16 11:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716112347.xvyucevt4bhbebc5@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).