From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
jiri@resnulli.us, jakub.kicinski@netronome.com
Subject: Re: [PATCH net,v3 1/4] net: openvswitch: rename flow_stats to sw_flow_stats
Date: Wed, 17 Jul 2019 15:16:25 -0700 (PDT) [thread overview]
Message-ID: <20190717.151625.1987585161672863516.davem@davemloft.net> (raw)
In-Reply-To: <20190717194248.2522-1-pablo@netfilter.org>
What is this series doing?
Where is your "0/4" cover letter which would tell us this?
Also:
> OVS compilation breaks here after this patchset since flow_stats
> structure is already defined in include/net/flow_offload.h. This patch
> is new in this batch.
You need to explain in more detail and in more context what this
means. Does the build break when this patch is applies? If so, why
is that OK?
I'm tossing this series until you submit it properly.
prev parent reply other threads:[~2019-07-17 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 19:42 [PATCH net,v3 1/4] net: openvswitch: rename flow_stats to sw_flow_stats Pablo Neira Ayuso
2019-07-17 19:42 ` [PATCH net,v3 2/4] net: flow_offload: remove netns parameter from flow_block_cb_alloc() Pablo Neira Ayuso
2019-07-17 19:42 ` [PATCH net,v3 3/4] net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t Pablo Neira Ayuso
2019-07-17 19:42 ` [PATCH net,v3 4/4] net: flow_offload: add flow_block structure and use it Pablo Neira Ayuso
2019-07-17 22:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717.151625.1987585161672863516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).