From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
jiri@resnulli.us, jakub.kicinski@netronome.com, pshelar@ovn.org
Subject: Re: [PATCH net,v4 0/4] flow_offload fixes
Date: Thu, 18 Jul 2019 12:39:39 -0700 (PDT) [thread overview]
Message-ID: <20190718.123939.886909513952061536.davem@davemloft.net> (raw)
In-Reply-To: <20190718175931.13529-1-pablo@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 18 Jul 2019 19:59:27 +0200
> The following patchset contains fixes for the flow_offload infrastructure:
>
> 1) Fix possible build breakage before patch 3/4. Both the flow_offload
> infrastructure and OVS define the flow_stats structure. Patch 3/4 in
> this batch indirectly pulls in the flow_stats definition from
> include/net/flow_offload.h into OVS, leading to structure redefinition
> compile-time errors.
>
> 2) Remove netns parameter from flow_block_cb_alloc(), this is not
> required as Jiri suggests. The flow_block_cb_is_busy() function uses
> the per-driver block list to check for used blocks which was the
> original intention for this parameter.
>
> 3) Rename tc_setup_cb_t to flow_setup_cb_t. This callback is not
> exclusive of tc anymore, this might confuse the reader as Jiri
> suggests, fix this semantic inconsistency.
>
> 4) Fix block sharing feature: Add flow_block structure and use it,
> update flow_block_cb_lookup() to use this flow_block object.
>
> Please, apply, thanks.
Series applied, thank you.
next prev parent reply other threads:[~2019-07-18 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 17:59 [PATCH net,v4 0/4] flow_offload fixes Pablo Neira Ayuso
2019-07-18 17:59 ` [PATCH net,v4 1/4] net: openvswitch: rename flow_stats to sw_flow_stats Pablo Neira Ayuso
2019-07-19 7:58 ` Jiri Pirko
2019-07-18 17:59 ` [PATCH net,v4 2/4] net: flow_offload: remove netns parameter from flow_block_cb_alloc() Pablo Neira Ayuso
2019-07-18 17:59 ` [PATCH net,v4 3/4] net: flow_offload: rename tc_setup_cb_t to flow_setup_cb_t Pablo Neira Ayuso
2019-07-18 17:59 ` [PATCH net,v4 4/4] net: flow_offload: add flow_block structure and use it Pablo Neira Ayuso
2019-07-19 8:01 ` Jiri Pirko
2019-07-18 19:39 ` David Miller [this message]
2019-07-18 20:36 ` [PATCH net,v4 0/4] flow_offload fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718.123939.886909513952061536.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).