From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [nft PATCH 1/3] meta: Reject zero ifindex values
Date: Thu, 18 Jul 2019 05:39:38 +0200 [thread overview]
Message-ID: <20190718033940.12820-1-phil@nwl.cc> (raw)
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
src/meta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/meta.c b/src/meta.c
index 1e8964eb48c4d..b12340991f35a 100644
--- a/src/meta.c
+++ b/src/meta.c
@@ -155,7 +155,7 @@ static struct error_record *ifindex_type_parse(const struct expr *sym,
errno = 0;
res = strtol(sym->identifier, &end, 10);
- if (res < 0 || res > INT_MAX || *end || errno)
+ if (res <= 0 || res > INT_MAX || *end || errno)
return error(&sym->location, "Interface does not exist");
ifindex = (int)res;
--
2.22.0
next reply other threads:[~2019-07-18 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 3:39 Phil Sutter [this message]
2019-07-18 3:39 ` [nft PATCH 2/3] meta: Reject nfproto value 0xffff Phil Sutter
2019-07-18 3:39 ` [nft PATCH 3/3] tests/py: Add missing meta tests Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718033940.12820-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).