From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D7C5C7618B for ; Thu, 25 Jul 2019 10:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D0F720823 for ; Thu, 25 Jul 2019 10:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726903AbfGYKYh (ORCPT ); Thu, 25 Jul 2019 06:24:37 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:43862 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726347AbfGYKYh (ORCPT ); Thu, 25 Jul 2019 06:24:37 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1hqavK-0001OB-Oz; Thu, 25 Jul 2019 12:24:34 +0200 Date: Thu, 25 Jul 2019 12:24:34 +0200 From: Florian Westphal To: wenxu@ucloud.cn Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/3] flow_offload: Support get tcf block immediately Message-ID: <20190725102434.c72m32tpsjwf7nff@breakpoint.cc> References: <1564048533-27283-1-git-send-email-wenxu@ucloud.cn> <1564048533-27283-2-git-send-email-wenxu@ucloud.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564048533-27283-2-git-send-email-wenxu@ucloud.cn> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org wenxu@ucloud.cn wrote: > From: wenxu > > It provide a callback to find the tcf block in > the flow_indr_block_dev_get Can you explain why you're making this change? This will help us understand the concept/idea of your series. The above describes what the patch does, but it should explain why this is callback is added.