From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: wenxu@ucloud.cn
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] flow_offload: move tc indirect block to flow offload
Date: Thu, 25 Jul 2019 12:10:29 -0700 [thread overview]
Message-ID: <20190725121029.75f26c2d@cakuba.netronome.com> (raw)
In-Reply-To: <1564048533-27283-1-git-send-email-wenxu@ucloud.cn>
Please provide cover letter for the patch set.
On Thu, 25 Jul 2019 17:55:31 +0800, wenxu@ucloud.cn wrote:
> +static bool rhash_table_init;
> +int flow_indr_rhashtable_init(void)
> +{
> + int err = 0;
> +
> + if (!rhash_table_init) {
> + err = rhashtable_init(&indr_setup_block_ht,
> + &flow_indr_setup_block_ht_params);
> +
> + if (!err)
> + rhash_table_init = true;
> + }
> +
> + return err;
> +}
> +EXPORT_SYMBOL_GPL(flow_indr_rhashtable_init);
This should be written like this:
int flow_indr_rhashtable_init(void)
{
static bool rhash_table_init;
int err;
if (rhash_table_init)
return 0;
err = rhashtable_init(&indr_setup_block_ht,
&flow_indr_setup_block_ht_params);
if (err)
return err;
rhash_table_init = true;
return 0;
}
EXPORT_SYMBOL_GPL(flow_indr_rhashtable_init);
prev parent reply other threads:[~2019-07-25 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:55 [PATCH net-next 1/3] flow_offload: move tc indirect block to flow offload wenxu
2019-07-25 9:55 ` [PATCH net-next 2/3] flow_offload: Support get tcf block immediately wenxu
2019-07-25 10:24 ` Florian Westphal
2019-07-25 10:59 ` wenxu
2019-07-25 9:55 ` [PATCH net-next 3/3] netfilter: nf_tables_offload: support indr block call wenxu
2019-07-25 10:20 ` [PATCH net-next 1/3] flow_offload: move tc indirect block to flow offload Pablo Neira Ayuso
2019-07-25 10:22 ` Florian Westphal
2019-07-25 10:53 ` wenxu
2019-07-25 19:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725121029.75f26c2d@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).