From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nftables 2/8] src: libnftnl: split nft_ctx_new/free
Date: Fri, 16 Aug 2019 16:42:35 +0200 [thread overview]
Message-ID: <20190816144241.11469-3-fw@strlen.de> (raw)
In-Reply-To: <20190816144241.11469-1-fw@strlen.de>
a followup patch doesn't need e.g. symbol files to be loaded,
so split those functions to create a helper that can be used
internally by nft to create a more minimal nft context.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
include/nftables.h | 3 +++
src/libnftables.c | 32 ++++++++++++++++++++++----------
2 files changed, 25 insertions(+), 10 deletions(-)
diff --git a/include/nftables.h b/include/nftables.h
index ef737c839b2e..b7fbcf5726d4 100644
--- a/include/nftables.h
+++ b/include/nftables.h
@@ -201,6 +201,9 @@ int nft_print(struct output_ctx *octx, const char *fmt, ...)
int nft_gmp_print(struct output_ctx *octx, const char *fmt, ...)
__attribute__((format(printf, 2, 0)));
+struct nft_ctx *__nft_ctx_new(void);
+void __nft_ctx_free(struct nft_ctx *ctx);
+
#define __NFT_OUTPUT_NOTSUPP UINT_MAX
#endif /* NFTABLES_NFTABLES_H */
diff --git a/src/libnftables.c b/src/libnftables.c
index b169dd2f2afe..a1e2fd662a7a 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -134,8 +134,7 @@ static void nft_ctx_netlink_init(struct nft_ctx *ctx)
ctx->nf_sock = nft_mnl_socket_open();
}
-EXPORT_SYMBOL(nft_ctx_new);
-struct nft_ctx *nft_ctx_new(uint32_t flags)
+struct nft_ctx *__nft_ctx_new(void)
{
static bool init_once;
struct nft_ctx *ctx;
@@ -149,18 +148,26 @@ struct nft_ctx *nft_ctx_new(uint32_t flags)
}
ctx = xzalloc(sizeof(struct nft_ctx));
- nft_init(ctx);
ctx->state = xzalloc(sizeof(struct parser_state));
nft_ctx_add_include_path(ctx, DEFAULT_INCLUDE_PATH);
- ctx->parser_max_errors = 10;
init_list_head(&ctx->cache.list);
- ctx->flags = flags;
ctx->output.output_fp = stdout;
ctx->output.error_fp = stderr;
- if (flags == NFT_CTX_DEFAULT)
- nft_ctx_netlink_init(ctx);
+ return ctx;
+}
+
+EXPORT_SYMBOL(nft_ctx_new);
+struct nft_ctx *nft_ctx_new(uint32_t flags)
+{
+ struct nft_ctx *ctx = __nft_ctx_new();
+
+ nft_init(ctx);
+
+ ctx->parser_max_errors = 10;
+ ctx->flags = flags;
+ nft_ctx_netlink_init(ctx);
return ctx;
}
@@ -281,20 +288,25 @@ const char *nft_ctx_get_error_buffer(struct nft_ctx *ctx)
return get_cookie_buffer(&ctx->output.error_cookie);
}
-EXPORT_SYMBOL(nft_ctx_free);
-void nft_ctx_free(struct nft_ctx *ctx)
+void __nft_ctx_free(struct nft_ctx *ctx)
{
if (ctx->nf_sock)
mnl_socket_close(ctx->nf_sock);
exit_cookie(&ctx->output.output_cookie);
exit_cookie(&ctx->output.error_cookie);
- iface_cache_release();
cache_release(&ctx->cache);
nft_ctx_clear_include_paths(ctx);
xfree(ctx->state);
xfree(ctx);
+}
+
+EXPORT_SYMBOL(nft_ctx_free);
+void nft_ctx_free(struct nft_ctx *ctx)
+{
nft_exit(ctx);
+ __nft_ctx_free(ctx);
+ iface_cache_release();
}
EXPORT_SYMBOL(nft_ctx_set_output);
--
2.21.0
next prev parent reply other threads:[~2019-08-16 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 14:42 [PATCH nftables 0/8] add typeof keyword Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 1/8] src: libnftnl: run single-initcalls only once Florian Westphal
2019-08-16 14:42 ` Florian Westphal [this message]
2019-08-16 14:42 ` [PATCH nftables 3/8] src: store expr, not dtype to track data in sets Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 4/8] src: parser: add syntax to provide bitsize for non-spcific types Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 5/8] src: add "typeof" keyword Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 6/8] src: add "typeof" print support Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 7/8] src: netlink: remove assertion Florian Westphal
2019-08-16 14:42 ` [PATCH nftables 8/8] tests: add typeof test cases Florian Westphal
2019-08-17 10:23 ` [PATCH nftables 0/8] add typeof keyword Pablo Neira Ayuso
2019-08-17 10:33 ` Pablo Neira Ayuso
2019-08-17 19:26 ` Florian Westphal
2019-08-17 20:55 ` Florian Westphal
2019-08-18 14:33 ` Arturo Borrero Gonzalez
2019-08-26 9:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816144241.11469-3-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).