From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF8DC3A59B for ; Sat, 17 Aug 2019 20:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCAFD21744 for ; Sat, 17 Aug 2019 20:55:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfHQUz4 (ORCPT ); Sat, 17 Aug 2019 16:55:56 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:50080 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfHQUzz (ORCPT ); Sat, 17 Aug 2019 16:55:55 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1hz5ju-0001pT-9T; Sat, 17 Aug 2019 22:55:54 +0200 Date: Sat, 17 Aug 2019 22:55:54 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nftables 0/8] add typeof keyword Message-ID: <20190817205554.iq7rfmvwzcugfmzc@breakpoint.cc> References: <20190816144241.11469-1-fw@strlen.de> <20190817102351.x2s2vj5hgvsi5vak@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190817102351.x2s2vj5hgvsi5vak@salvia> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > I know I sent a RFC using typeof(), I wonder if you could just use the > selector instead, it's a bit of a lot of type typeof() . typeof() > probably. > > So this is left as this: > > type osf name > > in concatenations, like this: > > nft add set ip filter allowed "{ type ip daddr . tcp dport; }" > > Probably I would ask my sysadmin friends what they think. Yes, please do, it would be good to get a non-developer perspective. I'm very used to things like sizeof(), so typeof() felt natural to me. Might be very un-intuitive for non-developers though, so it would be good to get outside perspective. Thanks!