From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Vlad Buslov <vladbu@mellanox.com>
Cc: wenxu <wenxu@ucloud.cn>, David Miller <davem@davemloft.net>,
Jiri Pirko <jiri@resnulli.us>,
"pablo@netfilter.org" <pablo@netfilter.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block
Date: Mon, 19 Aug 2019 13:27:57 -0700 [thread overview]
Message-ID: <20190819132757.0d00d34d@cakuba.netronome.com> (raw)
In-Reply-To: <vbftvady5tg.fsf@mellanox.com>
On Mon, 19 Aug 2019 07:26:07 +0000, Vlad Buslov wrote:
> On Fri 16 Aug 2019 at 20:56, Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> > Hi Vlad!
> >
> > While looking into this, would you mind also add the missing
> > flow_block_cb_is_busy() calls in the indirect handlers in the drivers?
> >
> > LMK if you're too busy, I don't want this to get forgotten :)
>
> Hi Jakub,
>
> I've checked the code and it looks like only nfp driver is affected:
>
> - I added check in nfp to lookup cb_priv with
> nfp_flower_indr_block_cb_priv_lookup() and call
> flow_block_cb_is_busy() if cb_priv exists.
>
> - In mlx5 en_rep.c there is already a check that indr_priv exists, so
> trying to lookup block_cb->cb_indent==indr_priv is redundant.
>
> - Switch drivers (mlxsw and ocelot) take reference to block_cb on
> FLOW_BLOCK_BIND, so they should not require any modifications.
>
> Tell me if I missed anything. Sending the patch for nfp.
Ah, that sounds plausible, I've only checked the nfp driver.
next prev parent reply other threads:[~2019-08-19 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 1:13 [PATCH net-next v7 0/6] flow_offload: add indr-block in nf_table_offload wenxu
2019-08-07 1:13 ` [PATCH net-next v7 1/6] cls_api: modify the tc_indr_block_ing_cmd parameters wenxu
2019-08-07 1:13 ` [PATCH net-next v7 2/6] cls_api: remove the tcf_block cache wenxu
2019-08-07 1:13 ` [PATCH net-next v7 3/6] cls_api: add flow_indr_block_call function wenxu
2019-08-07 1:13 ` [PATCH net-next v7 4/6] flow_offload: move tc indirect block to flow offload wenxu
2019-08-07 1:13 ` [PATCH net-next v7 5/6] flow_offload: support get multi-subsystem block wenxu
2019-08-12 14:11 ` Vlad Buslov
2019-08-14 2:50 ` wenxu
2019-08-16 15:04 ` Vlad Buslov
2019-08-16 17:56 ` Jakub Kicinski
2019-08-16 18:44 ` Vlad Buslov
2019-08-19 7:26 ` Vlad Buslov
2019-08-19 20:27 ` Jakub Kicinski [this message]
2019-08-07 1:13 ` [PATCH net-next v7 6/6] netfilter: nf_tables_offload: support indr block call wenxu
2019-08-09 1:44 ` [PATCH net-next v7 0/6] flow_offload: add indr-block in nf_table_offload David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819132757.0d00d34d@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vladbu@mellanox.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).