From: Florian Westphal <fw@strlen.de>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCHv3] netfilter: nfnetlink_log:add support for VLAN information
Date: Tue, 20 Aug 2019 15:18:39 +0200 [thread overview]
Message-ID: <20190820131839.GQ2588@breakpoint.cc> (raw)
In-Reply-To: <20190820131146.20787-1-michael-dev@fami-braun.de>
Michael Braun <michael-dev@fami-braun.de> wrote:
> Currently, there is no vlan information (e.g. when used with a vlan aware
> bridge) passed to userspache, HWHEADER will contain an 08 00 (ip) suffix
> even for tagged ip packets.
>
> Therefore, add an extra netlink attribute that passes the vlan information
> to userspace similarly to 15824ab29f for nfqueue.
>
> Signed-off-by: Michael Braun <michael-dev@fami-braun.de>
>
> --
> v2: mirror nfqueue behaviour
> v3: remove dep on CONFIG_BRIDGE_NETFILTER, allow NFPROTO_NETDEV, fix size calc
Looks good, thanks for addressing all the comments.
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-08-20 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 13:11 [PATCHv3] netfilter: nfnetlink_log:add support for VLAN information Michael Braun
2019-08-20 13:18 ` Florian Westphal [this message]
2019-08-26 9:30 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820131839.GQ2588@breakpoint.cc \
--to=fw@strlen.de \
--cc=michael-dev@fami-braun.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).