From: Florian Westphal <fw@strlen.de>
To: Eric Garver <eric@garver.life>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH nftables 3/3] src: mnl: retry when we hit -ENOBUFS
Date: Tue, 10 Sep 2019 00:12:18 +0200 [thread overview]
Message-ID: <20190909221218.GA2066@breakpoint.cc> (raw)
In-Reply-To: <20190909211110.2dzcta4dgengb4wy@egarver.localdomain>
Eric Garver <eric@garver.life> wrote:
> > + if (errno == ENOBUFS && enobuf_restarts++ < 3) {
> > + scale *= 2;
> > + goto restart;
> > + }
>
> If this restart is triggered it causes rules to be duplicated. We send
> the same batch again.
Right :-(
> I'm hitting this on x86_64. Maybe we need find a better way to estimate
> the rcvbuffer in the case of --echo. By the time we see ENOBUFS we're
> already in a bad way - events have already be lost.
Thats correct. Pablo, I don't see a way for dynamic probing, as Eric
explains the error occurs after the fact so we cannot recover.
I will send a best-effort fix in a bit.
prev parent reply other threads:[~2019-09-09 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 20:12 [PATCH v2 nftables 0/3] un-break nftables on big-endian arches Florian Westphal
2019-08-13 20:12 ` [PATCH nftables 1/3] src: fix jumps on bigendian arches Florian Westphal
2019-08-14 7:41 ` Pablo Neira Ayuso
2019-08-13 20:12 ` [PATCH nftables 2/3] src: parser: fix parsing of chain priority and policy on bigendian Florian Westphal
2019-08-14 7:42 ` Pablo Neira Ayuso
2019-08-13 20:12 ` [PATCH nftables 3/3] src: mnl: retry when we hit -ENOBUFS Florian Westphal
2019-08-14 7:42 ` Pablo Neira Ayuso
2019-09-09 21:11 ` Eric Garver
2019-09-09 22:12 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909221218.GA2066@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).