From: Jeremy Sowden <jeremy@azazel.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: [PATCH nf-next 0/7] ipset: remove static inline functions
Date: Thu, 3 Oct 2019 20:56:00 +0100 [thread overview]
Message-ID: <20191003195607.13180-1-jeremy@azazel.net> (raw)
In his feedback on an earlier patch series [0], Pablo suggested reducing
the number of ipset static inline functions.
0 - https://lore.kernel.org/netfilter-devel/20190808112355.w3ax3twuf6b7pwc7@salvia/
This series:
* removes inline from static functions in .c files;
* moves some static functions out of headers and removes inline from
them if they are only called from one .c file,
* moves some static functions out of headers, removes inline from them
and makes them extern if they are too big.
The changes reduced the size of the ipset modules by c. 13kB, when
compiled with GCC 9 on x86-64.
Jeremy Sowden (7):
netfilter: ipset: add a coding-style fix to ip_set_ext_destroy.
netfilter: ipset: remove inline from static functions in .c files.
netfilter: ipset: move ip_set_comment functions from ip_set.h to
ip_set_core.c.
netfilter: ipset: move functions to ip_set_core.c.
netfilter: ipset: make ip_set_put_flags extern.
netfilter: ipset: move function to ip_set_bitmap_ip.c.
netfilter: ipset: move ip_set_get_ip_port() to ip_set_bitmap_port.c.
include/linux/netfilter/ipset/ip_set.h | 196 +---------------
include/linux/netfilter/ipset/ip_set_bitmap.h | 14 --
.../linux/netfilter/ipset/ip_set_getport.h | 3 -
net/netfilter/ipset/ip_set_bitmap_gen.h | 2 +-
net/netfilter/ipset/ip_set_bitmap_ip.c | 26 ++-
net/netfilter/ipset/ip_set_bitmap_ipmac.c | 18 +-
net/netfilter/ipset/ip_set_bitmap_port.c | 41 +++-
net/netfilter/ipset/ip_set_core.c | 212 +++++++++++++++++-
net/netfilter/ipset/ip_set_getport.c | 28 ---
net/netfilter/ipset/ip_set_hash_gen.h | 4 +-
net/netfilter/ipset/ip_set_hash_ip.c | 10 +-
net/netfilter/ipset/ip_set_hash_ipmac.c | 8 +-
net/netfilter/ipset/ip_set_hash_ipmark.c | 8 +-
net/netfilter/ipset/ip_set_hash_ipport.c | 8 +-
net/netfilter/ipset/ip_set_hash_ipportip.c | 8 +-
net/netfilter/ipset/ip_set_hash_ipportnet.c | 24 +-
net/netfilter/ipset/ip_set_hash_mac.c | 6 +-
net/netfilter/ipset/ip_set_hash_net.c | 24 +-
net/netfilter/ipset/ip_set_hash_netiface.c | 24 +-
net/netfilter/ipset/ip_set_hash_netnet.c | 28 +--
net/netfilter/ipset/ip_set_hash_netport.c | 24 +-
net/netfilter/ipset/ip_set_hash_netportnet.c | 28 +--
net/netfilter/ipset/ip_set_list_set.c | 4 +-
23 files changed, 376 insertions(+), 372 deletions(-)
--
2.23.0
next reply other threads:[~2019-10-03 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 19:56 Jeremy Sowden [this message]
2019-10-03 19:56 ` [PATCH nf-next 1/7] netfilter: ipset: add a coding-style fix to ip_set_ext_destroy Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 2/7] netfilter: ipset: remove inline from static functions in .c files Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 3/7] netfilter: ipset: move ip_set_comment functions from ip_set.h to ip_set_core.c Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 4/7] netfilter: ipset: move functions " Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 5/7] netfilter: ipset: make ip_set_put_flags extern Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 6/7] netfilter: ipset: move function to ip_set_bitmap_ip.c Jeremy Sowden
2019-10-03 19:56 ` [PATCH nf-next 7/7] netfilter: ipset: move ip_set_get_ip_port() to ip_set_bitmap_port.c Jeremy Sowden
2019-10-07 20:08 ` [PATCH nf-next 0/7] ipset: remove static inline functions Kadlecsik József
2019-10-07 22:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003195607.13180-1-jeremy@azazel.net \
--to=jeremy@azazel.net \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).