From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH v2 nf-next 0/2] netfilter: conntrack: free extension area immediately
Date: Tue, 15 Oct 2019 15:19:13 +0200 [thread overview]
Message-ID: <20191015131915.28385-1-fw@strlen.de> (raw)
conntrack extensions are free'd via kfree_rcu, but there appears to be
no need for this anymore.
Lookup doesn't access ct->ext. All other accesses i found occur
after taking either the hash bucket lock, the dying list lock,
or a ct reference count.
Only exception was ctnetlink, where we could potentially see a
ct->ext that is about to be free'd via krealloc on other cpu.
Since that only affects unconfirmed conntracks, just skip dumping
extensions for those.
next reply other threads:[~2019-10-15 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 13:19 Florian Westphal [this message]
2019-10-15 13:19 ` [PATCH v2 nf-next 1/2] netfilter: ctnetlink: don't dump ct extensions of unconfirmed conntracks Florian Westphal
2019-10-15 13:19 ` [PATCH nf-next 2/2] netfilter: conntrack: free extension area immediately Florian Westphal
2019-10-17 9:50 ` [PATCH v2 nf-next 0/2] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015131915.28385-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).