From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C22C10F14 for ; Tue, 15 Oct 2019 13:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5F2521848 for ; Tue, 15 Oct 2019 13:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730441AbfJONP2 (ORCPT ); Tue, 15 Oct 2019 09:15:28 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:43588 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729551AbfJONP2 (ORCPT ); Tue, 15 Oct 2019 09:15:28 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iKMff-0003ki-Eq; Tue, 15 Oct 2019 15:15:27 +0200 From: Florian Westphal To: Subject: [PATCH v2 nf-next 0/2] netfilter: conntrack: free extension area immediately Date: Tue, 15 Oct 2019 15:19:13 +0200 Message-Id: <20191015131915.28385-1-fw@strlen.de> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org conntrack extensions are free'd via kfree_rcu, but there appears to be no need for this anymore. Lookup doesn't access ct->ext. All other accesses i found occur after taking either the hash bucket lock, the dying list lock, or a ct reference count. Only exception was ctnetlink, where we could potentially see a ct->ext that is about to be free'd via krealloc on other cpu. Since that only affects unconfirmed conntracks, just skip dumping extensions for those.