From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FDDECE58D for ; Thu, 17 Oct 2019 18:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82D1A21835 for ; Thu, 17 Oct 2019 18:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404087AbfJQSCz convert rfc822-to-8bit (ORCPT ); Thu, 17 Oct 2019 14:02:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403968AbfJQSCz (ORCPT ); Thu, 17 Oct 2019 14:02:55 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9686313FB6F7F; Thu, 17 Oct 2019 11:02:54 -0700 (PDT) Date: Thu, 17 Oct 2019 14:02:51 -0400 (EDT) Message-Id: <20191017.140251.1580977190222713975.davem@davemloft.net> To: ecree@solarflare.com Cc: pablo@netfilter.org, jakub.kicinski@netronome.com, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, jiri@resnulli.us, saeedm@mellanox.com, vishal@chelsio.com, vladbu@mellanox.com Subject: Re: [PATCH net-next,v5 3/4] net: flow_offload: mangle action at byte level From: David Miller In-Reply-To: References: <20191017161157.rr4lrolsjbnmk3ke@salvia> <20191017162237.h4e6bdoosd5b2ipj@salvia> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Oct 2019 11:02:55 -0700 (PDT) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Edward Cree Date: Thu, 17 Oct 2019 18:59:22 +0100 > Pedit is supposed to work even in the absence of protocol knowledge in >  the kernel (e.g. in combination with cls_u32, you can filter and mangle >  traffic in a completely new protocol), you're turning it into Yet >  Another Ossified TCP/IP Monoculture.  This is not the direction the >  networking offloads community is trying to move in. Agreed, the proposed changes are taking the code and interfaces in completely the wrong direction. I agree with Jakub and Edward on all of these points.