From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] xtables-restore: Fix --table parameter check
Date: Fri, 18 Oct 2019 22:58:08 +0200 [thread overview]
Message-ID: <20191018205808.GC25052@breakpoint.cc> (raw)
In-Reply-To: <20191018144806.GG26123@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> > How did you generate it? The added code is pure voodoo magic to me,
> > so I wonder if we can just remove the 'test for -t in iptables-restore
> > files' code.
>
> Sorry, I didn't mean to create such unreadable code. I guess after
> managing to wrap my head around to understand the old code, the new one
> seemed much more clear to me. ;)
Fair enough, my main point was where the test cases come from, i.e.
did you see such rule dumps in the wild, or did you create this manually
to catch all corner cases?
I see you have a test for things like "-?t", so I wondered where that
came from.
> What do you think? Or should I respin after adding a bunch of comments
> to is_table_param() to make it more clear?
I think thats the best option, I don't have any objections at the check
per se given older iptables does this too.
next prev parent reply other threads:[~2019-10-18 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 15:49 [iptables PATCH] xtables-restore: Fix --table parameter check Phil Sutter
2019-10-18 13:27 ` Phil Sutter
2019-10-18 14:05 ` Florian Westphal
2019-10-18 14:48 ` Phil Sutter
2019-10-18 20:58 ` Florian Westphal [this message]
2019-10-19 10:15 ` Phil Sutter
2019-10-19 13:34 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018205808.GC25052@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).